Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to fix Windows and Linux distributable #346

Merged
merged 20 commits into from
Sep 11, 2023
Merged

Conversation

CodyCBakerPhD
Copy link
Collaborator

Trying to fix windows side of current distributable errors related to Pydantic

@CodyCBakerPhD CodyCBakerPhD self-assigned this Sep 6, 2023
@CodyCBakerPhD
Copy link
Collaborator Author

@garrettmflynn 3 tests are passing according to log output for Windows here: https://github.com/NeurodataWithoutBorders/nwb-guide/actions/runs/6102263434/job/16560353693?pr=346

But CI itself is failing and says there are 'Errors' without reasons or tracebacks, any idea how to interpret this?

@garrettmflynn
Copy link
Member

This looks like it's fine. The executable test suite finishes without issue, causing the .exe to close—though this action seems to be something that registers as an error for the workflow.

The only outstanding issue is that an Error Code 1 is thrown by the latter. Not sure why or how we could figure that out—but I'll look into it

@CodyCBakerPhD
Copy link
Collaborator Author

This looks like it's fine. The executable test suite finishes without issue, causing the .exe to close—though this action seems to be something that registers as an error for the workflow.

The only outstanding issue is that an Error Code 1 is thrown by the latter. Not sure why or how we could figure that out—but I'll look into it

Fantastic! Exciting.

Yeah if you can figure out how to make the CI give the glorious green check that would be great, then I'll move onto the other platforms

@garrettmflynn
Copy link
Member

Found a solution on this issue: open-cli-tools/concurrently#187

Turns out this is a common problem, I'd tried using the --success flag originally but it turns out first means the first to exit when I thought it meant the first process in the list of those to run

@garrettmflynn
Copy link
Member

@CodyCBakerPhD Worked for both Windows and Linux! Unfortunately, we're running into the same Mac issue that @rly originally solved in #89...

@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review September 8, 2023 13:58
@CodyCBakerPhD
Copy link
Collaborator Author

@CodyCBakerPhD Worked for both Windows and Linux! Unfortunately, we're running into the same Mac issue that @rly originally solved in #89...

Awesome, thanks a bunch! We can tackle Mac in a follow-up then

@CodyCBakerPhD CodyCBakerPhD changed the title Trying to fix Windows distributable Trying to fix Windows and Linux distributable Sep 8, 2023
@CodyCBakerPhD CodyCBakerPhD merged commit aaabc04 into main Sep 11, 2023
6 of 7 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the try_windows_dist_fix branch September 11, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Testing]: Build easy specification for running PyFlask tests on dist rather than dev
3 participants