-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add data read #85
Draft
oruebel
wants to merge
69
commits into
main
Choose a base branch
from
add_read
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add data read #85
Changes from 62 commits
Commits
Show all changes
69 commits
Select commit
Hold shift + click to select a range
1e1f041
Define base classes for reading
oruebel e58f50f
First draft of reading datasets and attributes
oruebel 250a66b
Split reading of attribute and dataset to separate functions
oruebel e1bfa2e
Remove debug print
oruebel 4aedefd
Add functions to construct ReadDatasetWrapper and ReadAttributeWrappe…
oruebel 4dae171
Fix formatting
oruebel 140809e
Add test for using the ReadDatasetWrapper
oruebel 4d7b1ea
Start refactor containers for read
oruebel 2db4bfe
Fix format
oruebel b2959d2
Read ElectricalSeries.data example working
oruebel 37d30d3
Revert change to tests used for debugging
oruebel 6cfe416
Fix codespell issue
oruebel 3d86aff
Move read example to an example file
oruebel 3fc1d7a
Fix bug in Container::create
oruebel b09a4fa
Add example for data read
oruebel 970f4c8
Fix spelling error
oruebel 26fbae9
Add user docs for data read
oruebel 4299f99
Update read user docs
oruebel 9c9301c
Add toc
oruebel 447337a
Add read software design figure and more details on the design
oruebel e3d4330
Some adjustment to the edges in the fig
oruebel 77f0861
Some adjustment to the edges in the fig
oruebel 5190731
Add intro for data read page
oruebel f08e42f
Make Container::create inline
oruebel 1a754b9
Make DataBlock::fromGeneric inline
oruebel ebfbdf1
Implement function to allow us to get the storage object type for a g…
oruebel 3022861
Rename getObjectType to getStroageObjectType
oruebel 6ba32a5
Fix reading of attributes and add TimeSeries.resolution read
oruebel 1fb5d95
Add example for reading an attribute
oruebel 676b978
Add ReadDataWrapperBase as common base class for ReadDatasetWrapper a…
oruebel 14c8362
Fix docstring
oruebel d2b1c23
Minor fixed to docs
oruebel 78825f2
Mention ReadDataWrapperBase in the read dox page
oruebel 85db320
Merge branch 'main' into add_read
oruebel 5c2faae
Fix unit tests after merge
oruebel c481260
Remove NWBFile.identifierText property
oruebel b418149
Allow setting of value type template parameter for ReadDataWrapperBas…
oruebel 1f3ad24
Save the std::type_index as part of the DataBlock to support runtime …
oruebel 99b5d4e
Fix #88 move io classes to their own module
oruebel 04117e9
Refactor to add IO namespace to match folder structure
oruebel 82a4c08
Move HDF5RecordingData to its own hpp/cpp files
oruebel 6554e29
Moved read I/O classes to new ReadIO.hpp
oruebel bff7121
Refactor the read data wrappers to use a single ReadDataWrapper class…
oruebel 53365ff
Replace redundant ReadObjectType with StorageObjectType
oruebel c66b3bc
Add traits for ReadObjectWrapper to prevent instantiation for Group a…
oruebel 0da4800
Fix formatting
oruebel d161c47
Fix spelling error
oruebel 58e5afb
Inline functions in ReadIO.hpp
oruebel b7cc149
Some minor fixes
oruebel b9c6c9b
Merge branch 'main' into add_read
oruebel 69c3c4e
Update ElectrodGroup to provide standard Container constructor and mo…
oruebel e75c7ad
Fix formatting
oruebel 5ab8464
Merge branch 'main' into add_read
oruebel 803dfcf
Fix ElectricalSeries
oruebel cdffc74
Run test workflows on all PRs
oruebel 89f6d29
Fix static assert for ReadDataWrapper
oruebel 5608c5a
Sync add_read with main branch (#101)
oruebel c7ced4e
Merge branch 'main' into add_read
oruebel dd01ad3
Merge branch 'main' into add_read
oruebel 968fcf0
Fix formatting and docs error after merge with main
oruebel bfaabb8
Update docs/pages/userdocs/read.dox
oruebel a439212
Update src/io/ReadIO.hpp
oruebel 5f28fb0
Update src/io/ReadIO.hpp
oruebel a9725b2
Rename ReadDataWrapper.is_dataset
oruebel e70949c
Update src/io/hdf5/HDF5IO.hpp
oruebel d1da5d1
Remove duplicate code in NWBFile
oruebel 12a86a5
Remove outdated ToDo item
oruebel ae66f33
Merge branch 'main' into add_read
oruebel 69df3e0
Fix build error after merge
oruebel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,8 +6,8 @@ on: | |
- main | ||
|
||
pull_request: | ||
branches: | ||
- main | ||
#branches: | ||
#- main | ||
workflow_dispatch: | ||
|
||
jobs: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,8 +6,8 @@ on: | |
- main | ||
|
||
pull_request: | ||
branches: | ||
- main | ||
#branches: | ||
#- main | ||
workflow_dispatch: | ||
|
||
jobs: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,4 +7,5 @@ | |
* - \subpage user_install_page | ||
* - \subpage workflow | ||
* - \subpage hdf5io | ||
* - \subpage read_page | ||
*/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uncomment workflow triggers before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason I had modified this is because it would'nt trigger workflows if they didn't target the main branch. I think it would be useful to run the tests on all PRs, even if they target branches other than
main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, that makes sense. We can remove the branch section entirely then or yes just leave it commented out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either way is fine. I just commented them out here, because I wanted to see what tests are working/failing on this PR. We can change workflows also in a separate PR and remove this change here before merging if you prefer.