Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup for user and developer documentation #74

Merged
merged 31 commits into from
Aug 26, 2024
Merged
Show file tree
Hide file tree
Changes from 30 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
7d19af1
Add outline for adding user and developer documentation
oruebel Aug 8, 2024
bc4b68c
Merge branch 'main' into start_user_docs
oruebel Aug 8, 2024
6aff062
Add flush function for the IO and fix test build warnings for testHDF5IO
oruebel Aug 9, 2024
58b515c
Add HDF5 example code snippet that is run in the tests
oruebel Aug 9, 2024
cbc0631
Fix lint issues
oruebel Aug 9, 2024
b175b17
Fix codespell
oruebel Aug 9, 2024
ba9fcc4
Fix lint
oruebel Aug 9, 2024
f8577d3
Move examples to tests/examples subfolder
oruebel Aug 15, 2024
a0d4f62
Update line breaks in LICENSE
oruebel Aug 15, 2024
443620a
Add legal abd build instructions to the docs
oruebel Aug 15, 2024
07d0e69
Attempt to fix test failure
oruebel Aug 21, 2024
c97caa7
Add codespell to the requirements
oruebel Aug 21, 2024
d904ca1
Add Doxygen commands to the codespell ignore list
oruebel Aug 21, 2024
a869fdb
Add brief testing docs
oruebel Aug 21, 2024
a4ed61c
Add HDF5 I/O SWMR and Chunking docs
oruebel Aug 21, 2024
5ffdea6
Add docstrings for namespaces
oruebel Aug 21, 2024
19b2660
Move install docs and diverse fixes
oruebel Aug 21, 2024
711b6e1
Add example with SMWR disabled
oruebel Aug 21, 2024
44dc911
Add dot figures for the HDF5IO docs
oruebel Aug 22, 2024
66cb457
Fix section levels
oruebel Aug 22, 2024
fbac49d
Add format-fix and spell-fix targets in the docs
oruebel Aug 22, 2024
da190c2
Apply suggestions from code review
oruebel Aug 24, 2024
c05a2e3
Separate User and Developer installation docs
oruebel Aug 25, 2024
686a1a3
Apply suggestions from code review
oruebel Aug 25, 2024
e8cf56d
Update docs/pages/2_devdocs.dox
oruebel Aug 25, 2024
ae3dd83
Add links to the installation docs on the README.md page
oruebel Aug 25, 2024
5736bc3
Merge branch 'start_user_docs' of https://github.com/lbl-cbg/aq-nwb i…
oruebel Aug 25, 2024
d660b60
Add documentation on how to write Documentation in Doxygen
oruebel Aug 25, 2024
046c292
Fix format check errors
oruebel Aug 25, 2024
760772f
Update tests/CMakeLists.txt
oruebel Aug 26, 2024
62fc6f7
Apply suggestions from code review
oruebel Aug 26, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .codespell_ignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
endcode
code
param
brief
retval
3 changes: 2 additions & 1 deletion .codespellrc
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
builtin = clear,rare,en-GB_to_en-US,names,informal,code
check-filenames =
check-hidden =
skip = */.git,*/build,*/prefix,*/resources,*/.vscode
skip = */.git,*/build,*/prefix,*/resources,*/.vscode,*/libs
quiet-level = 2
ignore-words=./.codespell_ignore
14 changes: 11 additions & 3 deletions LICENSE
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,17 @@ may be used to endorse or promote products derived from this software
without specific prior written permission.


THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE
LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
THE POSSIBILITY OF SUCH DAMAGE.

You are under no obligation whatsoever to provide any bug fixes, patches,
or upgrades to the features, functionality or performance of the source
Expand Down
192 changes: 21 additions & 171 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,187 +8,37 @@
[![Docs](https://img.shields.io/badge/AqNWB-Docs-8A2BE2?style=flat)](https://neurodatawithoutborders.github.io/aqnwb/)
[![Code Stats](https://img.shields.io/badge/AqNWB-Code%20Statistics-8A2BE2?style=flat)](https://nwb-overview.readthedocs.io/en/latest/nwb-project-analytics/docs/source/code_stat_pages/AqNWB_stats.html)

**AqNWB is currently under active development and should not yet be used in practice.**

AqNWB is a C++ API for acquiring neurophysiological data directly into the NWB (Neurodata Without Borders) format.
Our goal is to provide a lightweight API to integrate with existing acquisition systems.

Please note, AqNWB is currently under development and should not yet be used in practice.
Please see the [AqNWB Documentation](https://neurodatawithoutborders.github.io/aqnwb/) for
installation instructions and to learn more about AqNWB.

Below is a high-level overview of the project structure and capabilities we are targeting:

![Project Overview](resources/images/aqnwb_objective_500px.png)


# Requirements
* A C++17-compliant compiler
* CMake `>= 3.15`
* HDF5 `>= 1.10`
* Boost
* Additional requirements for building the documentation (optional)
* Doxygen
* Graphviz
* Additional requirements for developers (mode `dev`)
* cppcheck
* clang-format
<a id="requirements"></a>
## Requirements

# Building and installing
- **Minimum Requirements:**
- A C++17-compliant compiler
- [CMake >= 3.15](https://cmake.org)
- [HDF5 >= 1.10](https://github.com/HDFGroup/hdf5)
- [Boost](https://www.boost.org/)
- **Documentation:** Additional requirements for building the documentation (optional)
- [Doxygen](https://www.doxygen.nl/)
- [Graphviz](https://graphviz.org/)
- **For Developers:** Additional requirements for developers (mode `dev`)
- cppcheck
- clang-format (optional, required for ``target=format-check``, ``target=format-fix``)
- codespell (optional, required for ``target=spell-check``, ``target=spell-fix``)

## Build
## Installation

Here are the steps for building in release mode with a multi-configuration generator:

```sh
cmake -S . -B build
cmake --build build --config Release
```

Note, if you are using custom installations of HDF5 or BOOST that are not being detected
automatically by cmake, you can specify `HDF5_ROOT` and `BOOST_ROOT` environment variables to
point to install directories of HDF5 and BOOST respectively.


## Install

Here is the command for installing the release mode artifacts with a
multi-configuration generator:

```sh
cmake --install build --config Release
```

## Developing

Build system targets that are only useful for developers of this project are
hidden if the `aq-nwb_DEVELOPER_MODE` option is disabled. Enabling this
option makes tests and other developer targets and options available. You can enable
the option when configuring the build by adding ``-Daq-nwb_DEVELOPER_MODE=ON``, e.g.,:

```sh
cmake -S . -B build -Daq-nwb_DEVELOPER_MODE=ON
```
### Presets

As a developer, you can create your own dev preset by making a `CMakeUserPresets.json` file at the root of
the project:

```json
{
"version": 2,
"cmakeMinimumRequired": {
"major": 3,
"minor": 15,
"patch": 0
},
"configurePresets": [
{
"name": "dev",
"binaryDir": "${sourceDir}/build/dev",
"inherits": ["dev-mode", "ci-<os>"],
"cacheVariables": {
"CMAKE_BUILD_TYPE": "Debug"
}
}
],
"buildPresets": [
{
"name": "dev",
"configurePreset": "dev",
"configuration": "Debug"
}
],
"testPresets": [
{
"name": "dev",
"configurePreset": "dev",
"configuration": "Debug",
"output": {
"outputOnFailure": true
}
}
]
}
```
Replace `<os>` in the `CmakeUserPresets.json` file with the name of
the operating system you have (`win64`, `linux` or `darwin`).

### Configure, build and test

You can configure, build and test the project respectively with the following commands from the project root on
any operating system with any build system:

```sh
cmake --preset=dev
cmake --build --preset=dev
ctest --preset=dev
```

### Developer mode targets

Additional targets can be invoked when in development mode using the commands below

```sh
cmake --build --preset=dev --target=<name of the target>
```

#### Target options
- `format-check` and `format-fix`: run the clang-format tool on the codebase to check errors and to fix them respectively.
- `spell-check` and `spell-fix`: run the codespell tool on the codebase to check errors and to fix them respectively.
- `docs` : builds to documentation using Doxygen. (Note: run `cmake --preset=dev -DBUILD_DOCS=ON` before building to add docs target)

# Code of Conduct

This project and everyone participating in it is govered by our [code of conduct guidelines](https://github.com/NeurodataWithoutBorders/aqnwb/blob/main/.github/CODE_OF_CONDUCT.md). By participating, you are expected to uphold this code.

# LICENSE

AqNWB Copyright (c) 2024, The Regents of the University of California,
through Lawrence Berkeley National Laboratory (subject to receipt of any
required approvals from the U.S. Dept. of Energy). All rights reserved.

Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are met:

(1) Redistributions of source code must retain the above copyright notice,
this list of conditions and the following disclaimer.

(2) Redistributions in binary form must reproduce the above copyright
notice, this list of conditions and the following disclaimer in the
documentation and/or other materials provided with the distribution.

(3) Neither the name of the University of California, Lawrence Berkeley
National Laboratory, U.S. Dept. of Energy nor the names of its contributors
may be used to endorse or promote products derived from this software
without specific prior written permission.


THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

You are under no obligation whatsoever to provide any bug fixes, patches,
or upgrades to the features, functionality or performance of the source
code ("Enhancements") to anyone; however, if you choose to make your
Enhancements available either publicly, or directly to Lawrence Berkeley
National Laboratory, without imposing a separate written license agreement
for such Enhancements, then you hereby grant the following license: a
non-exclusive, royalty-free perpetual license to install, use, modify,
prepare derivative works, incorporate into other computer software,
distribute, and sublicense such enhancements or derivative works thereof,
in binary and source code form.

# COPYRIGHT

AqNWB Copyright (c) 2024, The Regents of the University of California,
through Lawrence Berkeley National Laboratory (subject to receipt of any
required approvals from the U.S. Dept. of Energy). All rights reserved.

If you have questions about your rights to use or distribute this software,
please contact Berkeley Lab's Intellectual Property Office at
[email protected].

NOTICE. This Software was developed under funding from the U.S. Department
of Energy and the U.S. Government consequently retains certain rights. As
such, the U.S. Government has been granted for itself and others acting on
its behalf a paid-up, nonexclusive, irrevocable, worldwide license in the
Software to reproduce, distribute copies to the public, prepare derivative
works, and perform publicly and display publicly, and to permit others to do so.
See the [AqNWB Documentation](https://neurodatawithoutborders.github.io/aqnwb/) for installation and integration instructions.
* [User Installation](https://neurodatawithoutborders.github.io/aqnwb/install_page.html)
* [Developer Installation](https://neurodatawithoutborders.github.io/aqnwb/dev_install_page.html)
4 changes: 4 additions & 0 deletions docs/Doxyfile.in
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,15 @@ PROJECT_NUMBER = "@PROJECT_VERSION@"

# Add sources
INPUT = "@PROJECT_SOURCE_DIR@/README.md" "@PROJECT_SOURCE_DIR@/src" "@PROJECT_SOURCE_DIR@/docs/pages"
EXAMPLE_PATH = "@PROJECT_SOURCE_DIR@/tests" "@PROJECT_SOURCE_DIR@/.github/CODE_OF_CONDUCT.md" "@PROJECT_SOURCE_DIR@/Legal.txt" "@PROJECT_SOURCE_DIR@/LICENSE"
IMAGE_PATH = "@PROJECT_SOURCE_DIR@/resources/images"
EXTRACT_ALL = YES
RECURSIVE = YES
OUTPUT_DIRECTORY = "@DOXYGEN_OUTPUT_DIRECTORY@"

# Enable Markdown support
MARKDOWN_SUPPORT = YES

# Use the README as a main page
USE_MDFILE_AS_MAINPAGE = "@PROJECT_SOURCE_DIR@/README.md"

Expand Down
9 changes: 9 additions & 0 deletions docs/pages/1_userdocs.dox
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
/**
* @page userdocs For Users
*
* This documentation is intended for users of AqNWB, e.g., developers seeking to integrate NWB
* with a particular data acquisition software via AqNWB.
*
* - @subpage install_page
* - @subpage hdf5io
*/
13 changes: 13 additions & 0 deletions docs/pages/2_devdocs.dox
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
/**
* @page devdocs For Developers
*
* This documentation is intended for developers of AqNWB.
*
* - @subpage dev_install_page
* - @subpage testing
* - @subpage dev_docs_page
* - @subpage code_of_conduct_page
* - @subpage license_page
* - @subpage copyright_page
*
*/
7 changes: 0 additions & 7 deletions docs/pages/about.dox

This file was deleted.

7 changes: 7 additions & 0 deletions docs/pages/devdocs/code_of_conduct.dox
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
/**
* @page code_of_conduct_page Code of Conduct
*
* This project and everyone participating in it is governed by our code of conduct guidelines. By participating, you are expected to uphold this code.
* \include CODE_OF_CONDUCT.md
*/

6 changes: 6 additions & 0 deletions docs/pages/devdocs/copyright.dox
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
/**
* @page copyright_page Copyright
*
* \include Legal.txt
*/

Loading
Loading