Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup for user and developer documentation #74

Merged
merged 31 commits into from
Aug 26, 2024
Merged

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented Aug 8, 2024

This PR adds the basic setup for creating custom pages for the user and developer documentation. Currently this looks as follows.

Screen Shot 2024-08-21 at 12 51 31 AM

CHANGES

  • Basic Setup
    • Added setup for creating User Docs and Developer Docs sections
    • Added setup for creating testable code examples as part of the tests/examples folder. The code in the folder is being executed with the regular tests, but has additional markup to be able to include specific sections of the code in the docs. In this way the code snippets in the docs are being tests with the regular test suite.
    • Added .codespell_ignore file to ignore Doxygen commands when running codespell
  • New Documentation Pages
    • Moved requirements and installation instructions from the README to a dedicated page in the docs
    • Moved LICENCE and COPYRIGHT pages from the README to the docs
    • Added brief developer docs about testing
    • Add docs for SWMR mode and chunking in HDF5
    • Add example for making dot figures inline as part of the HDF5IO docs
    • Add documentation about how to write Docs (including code examples)
  • Source Code Changes
    • Added BaseIO::flush() and HDF5IO::flush()
    • Fixed format conversion warnings in HDF5 tests
    • Added missing docstrings for namespaces

TODO (possibly for future PR)

  • Expand the testing docs to also include other tests (e.g., sanitize) that a user should run
  • Add developer dosc about how to edit documentation
  • Add Getting Started page for users
  • Add tutorial on how to integrate AqNWB with a data acquisition system
  • Add docs on how to implement an alternate storage backend

@oruebel
Copy link
Contributor Author

oruebel commented Aug 8, 2024

@stephprince would you prefer we define the basic setup here first and then add actual content for the docs in a separate PR or would you like me to add content (e.g., to describe SWMR) in this PR, so that we one PR for documentation content?

@stephprince
Copy link
Collaborator

@oruebel I'm ok adding content all in this PR, so we don't have placeholders and since the folder structure may change as you make the content.

@oruebel oruebel marked this pull request as ready for review August 21, 2024 07:58
@oruebel oruebel requested a review from stephprince August 21, 2024 07:58
@oruebel
Copy link
Contributor Author

oruebel commented Aug 21, 2024

@stephprince please take a look. The main setup, outline, and a few additional docs pages are there. Given that this PR is already getting pretty big, I think it may be useful to use separate PR's to add more content to the docs.

Copy link
Collaborator

@stephprince stephprince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the documentation and the diagrams look great! Added my suggestions.

README.md Outdated Show resolved Hide resolved
docs/pages/2_devdocs.dox Outdated Show resolved Hide resolved
docs/pages/devdocs/testing.dox Outdated Show resolved Hide resolved
docs/pages/devdocs/testing.dox Outdated Show resolved Hide resolved
docs/pages/userdocs/install.dox Outdated Show resolved Hide resolved
docs/pages/userdocs/install.dox Outdated Show resolved Hide resolved
tests/CMakeLists.txt Outdated Show resolved Hide resolved
docs/pages/userdocs/hdf5io.dox Show resolved Hide resolved
docs/pages/userdocs/hdf5io.dox Show resolved Hide resolved
@oruebel
Copy link
Contributor Author

oruebel commented Aug 25, 2024

@stephprince can you take another look. I believe I've addressed all your comments. I also added a new page to describe some of the details about how to add content to the documentation.

tests/CMakeLists.txt Outdated Show resolved Hide resolved
Copy link
Collaborator

@stephprince stephprince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small changes to the section about adding new documentation but otherwise looks good!

docs/pages/devdocs/documentation.dox Outdated Show resolved Hide resolved
docs/pages/devdocs/documentation.dox Outdated Show resolved Hide resolved
docs/pages/devdocs/documentation.dox Outdated Show resolved Hide resolved
docs/pages/devdocs/documentation.dox Outdated Show resolved Hide resolved
@oruebel
Copy link
Contributor Author

oruebel commented Aug 26, 2024

A few small changes to the section about adding new documentation but otherwise looks good!

Thanks for the additional comments. I committed all your suggestions.

@oruebel oruebel merged commit 603c8ed into main Aug 26, 2024
6 checks passed
@oruebel oruebel deleted the start_user_docs branch August 26, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants