Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for missing channels in SpikeGadgets #1593

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pauladkisson
Copy link

Fixes #1592

@zm711
Copy link
Contributor

zm711 commented Nov 3, 2024

Do you have a small test file we could include. Some of these spike gadget edge cases are starting to bite us. I would love if we had some way to actually test against these edge cases so we don't break this in the future?

@pauladkisson
Copy link
Author

I have a test file, but it's not small (27GB). Do you know how to stub a spike gadgets .rec file?

@zm711
Copy link
Contributor

zm711 commented Nov 4, 2024

I think @samuelgarcia knows this format a bit better. So might be worth pinging him or @alejoe91 to see if they know how. Our limit is 10MB so 27GB is definitely over haha. We will see what se can do. :)

@pauladkisson
Copy link
Author

Actually, to test this fix we should just need the header, which should be relatively easy to stub. I'll see what I can do...

@pauladkisson
Copy link
Author

Ok, I was able to stub the file to just include the header (no data) and now it's only 72KB. Still awaiting permission from the original researchers to share with y'all, but once I get that, I will send over the stubbed file.

@zm711
Copy link
Contributor

zm711 commented Nov 5, 2024

Thanks Paul, that would be awesome. This was originally caused by trying to explicitly support Intan chips which was maybe the wrong move. Previously we just gave arbitrary names to the channels which worked for everything, but was unclear to the user. If we can name things correctly both for NP and Intan that would be the best, but I don't know this system at all. Really appreciate your help on this :)

@pauladkisson
Copy link
Author

Hey @zm711, Github doesn't support .rec as a file type, so I can't upload it here. What is the best way to share this file with you?

@zm711
Copy link
Contributor

zm711 commented Nov 5, 2024

The options are you can zip it and include on github or you can email it to me. Do you have a preference?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SpikeGadgetsRawIO Gives incorrect channel ids with recording missing hardware channels
2 participants