Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Interfaces for SpikeGadgets and Video #2

Merged
merged 10 commits into from
Nov 11, 2024
Merged

Conversation

pauladkisson
Copy link
Member

Adds Neuroconv's VideoInterface, and a semi-custom Olson2024SpikeGadgetsRecordingInterface(SpikeGadgetsRecordingInterface) to appropriately handle all the metadata.

This PR depends on this fix for neo.

@@ -3,7 +3,7 @@ channels:
- conda-forge
- defaults
dependencies:
- python>=3.9
- python>=3.9, <3.13
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neo doesn't support 3.13 yet.

@pauladkisson
Copy link
Member Author

Copy link
Contributor

@alessandratrapani alessandratrapani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Just a small note, I can see two devices in the stub nwbfile, one is called DeviceEcephys and the other one ProbeNameTBD. I guess they refer to the same device but the first is added by default, you might want to remove that. Correct me if I am wrong.

@pauladkisson
Copy link
Member Author

LGTM. Just a small note, I can see two devices in the stub nwbfile, one is called DeviceEcephys and the other one ProbeNameTBD. I guess they refer to the same device but the first is added by default, you might want to remove that. Correct me if I am wrong.

Yeah, that's right. I will need to remove the default device when I get the probe info from Jacob.

@pauladkisson pauladkisson merged commit 4add0e7 into main Nov 11, 2024
1 check failed
@pauladkisson pauladkisson deleted the neuroconv_interfaces branch November 11, 2024 16:13
@pauladkisson pauladkisson mentioned this pull request Nov 21, 2024
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants