-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release notes for 0.13.1, plus an update to the list of authors. #1469
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
======================== | ||
Neo 0.13.1 release notes | ||
======================== | ||
|
||
7th May 2024 | ||
|
||
|
||
This release of Neo contains a lot of improvements to code quality and documentation, | ||
still with a focus on the planned 1.0 release, | ||
together with, as usual, bug fixes and performance improvements in IO modules. | ||
|
||
See all `pull requests`_ included in this release and the `list of closed issues`_. | ||
|
||
Code and documentation quality | ||
------------------------------ | ||
|
||
Particular thanks go to Zach McKenzie, who has checked, and rewritten if necessary, every docstring in the project, | ||
to ensure they all have a consistent style. | ||
Zach has also updated and improved the :doc:`../examples/index` in the Sphinx documentation. | ||
|
||
The Neo code base contained a lot of ``assert``\s that should be exceptions. | ||
These have all been replaced with appropriate exceptions (again by Zach McKenzie). | ||
A new exception class, :class:`NeoReadWriteError` has been introduced. | ||
|
||
Bug fixes and improvements in IO modules | ||
---------------------------------------- | ||
|
||
Bug fixes and/or improvements have been made to :class:`SpikeGLXIO`, :class:`OpenEphysIO`, :class:`SpikeGadgetsIO`, | ||
:class:`MaxwellIO`, :class:`AxonIO`, :class:`IntanIO`, :class:`TDTIO`, :class:`NeuralynxIO` and :class:`BlackrockIO`. | ||
|
||
|
||
Acknowledgements | ||
---------------- | ||
|
||
Thanks to Zach McKenzie, Andrew Davison, Heberto Mayorquin, Alessio Buccino, Samuel Garcia, Peter N. Steinmetz, | ||
Aitor Morales-Gregorio, Greg Knoll, Chris Halcrow and Szonja Weigl for their contributions to this release. | ||
|
||
.. generated with git shortlog --since=2024-02-02 -sne then checking Github for PRs merged since the last release but with commits before then | ||
|
||
.. _`list of closed issues`: https://github.com/NeuralEnsemble/python-neo/issues?q=is%3Aissue+milestone%3A0.13.1+is%3Aclosed | ||
.. _`pull requests`: https://github.com/NeuralEnsemble/python-neo/pulls?q=is%3Apr+is%3Aclosed+merged%3A%3E2024-02-02+milestone%3A0.13.1 | ||
.. _`examples gallery`: https://neo.readthedocs.io/en/latest/examples/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@apdavison could you change my affiliation 23. to "Allen Institute for Neural Dynamics, Seattle, WA, United States"
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is affiliation 23 incorrect (i.e. you never worked there, or didn't contribute to Neo while you worked there), or is it that you moved?
If it's just that you moved, then I would add the Allen Institute as a second affiliation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and I guess we should add CatalystNeuro as a third affiliation in that case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @apdavison
Yeah the institutution is correct, but I wonder whether we should keep all past institutions...What do you think?
IMO, it's better to keep the current institution(s), which for me are Allen Institute + CatalystNeuro
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Past institutions are potential copyright co-owners, so we need to keep track of them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If that's the case then I should probably add a second affiliation (I can do a PR myself soon). My MD/PhD will be from Harvard but my current lab is at Massachusetts General Hospital.