Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release notes for 0.13.1, plus an update to the list of authors. #1469

Merged
merged 1 commit into from
May 7, 2024

Conversation

apdavison
Copy link
Member

These notes assume that #1338 gets merged before the release. If it doesn't get merged, remove the mention of BlackrockIO.

Note that I added affiliations for new contributors where I could find them. If you see yourself in the author list and there's no affiliation given, please let us know in the comments if you'd like your affiliation to be added. If there's an error in your affiliation, please also let us know.

@apdavison apdavison added this to the 0.13.1 milestone May 6, 2024
@apdavison apdavison requested a review from a team May 6, 2024 15:25
@alejoe91
Copy link
Contributor

alejoe91 commented May 6, 2024

@apdavison can we wait for this #1457 too?

@apdavison
Copy link
Member Author

apdavison commented May 6, 2024

sure. I was planning to make the release at the end of the afternoon tomorrow (Tuesday 7th May)

@zm711
Copy link
Contributor

zm711 commented May 6, 2024

Perfect, both the PRs have tests passing. @samuelgarcia had mentioned that he was going to look at #1338 previously so not sure if he wants to give that a look-over before or not. I took a quick look at it and it seemed fine, but I'm not super familiar with BlackRock. #1457 should be ready for merge as well by tomorrow morning. So sounds good to me.

Release notes look good to me.

@samuelgarcia
Copy link
Contributor

@zm711 : #1338 is OK for me. merci.

@@ -108,6 +112,16 @@ and may not be the current affiliation of a contributor.
26. Georgia Institute of Technology
27. Emory University
28. Harvard Medical School
29. Institute for Advanced Simulation (IAS-6), Forschungszentrum Jülich, Germany
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apdavison could you change my affiliation 23. to "Allen Institute for Neural Dynamics, Seattle, WA, United States"
?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is affiliation 23 incorrect (i.e. you never worked there, or didn't contribute to Neo while you worked there), or is it that you moved?

If it's just that you moved, then I would add the Allen Institute as a second affiliation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and I guess we should add CatalystNeuro as a third affiliation in that case?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @apdavison

Yeah the institutution is correct, but I wonder whether we should keep all past institutions...What do you think?
IMO, it's better to keep the current institution(s), which for me are Allen Institute + CatalystNeuro

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Past institutions are potential copyright co-owners, so we need to keep track of them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that's the case then I should probably add a second affiliation (I can do a PR myself soon). My MD/PhD will be from Harvard but my current lab is at Massachusetts General Hospital.

@apdavison apdavison merged commit 97099e2 into NeuralEnsemble:master May 7, 2024
42 checks passed
@zm711
Copy link
Contributor

zm711 commented May 7, 2024

Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants