Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PPA package post-install script #5991

Merged
merged 4 commits into from
Sep 28, 2023
Merged

Fix PPA package post-install script #5991

merged 4 commits into from
Sep 28, 2023

Conversation

rubo
Copy link
Contributor

@rubo rubo commented Aug 9, 2023 •
edited
Loading

Changes

  • Fixed the PPA package post-install script to download resources from the latest release branch instead of the main one.
  • Replaced wget with curl
  • Optimized jq queries

To be merged right before the release of #5908

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Tested manually as a standalone shell script but not in the context of PPA.

Documentation

Requires documentation update

  • Yes
  • No

Requires explanation in Release Notes

  • Yes
  • No

@rubo rubo added the devops label Aug 9, 2023
@rubo rubo requested a review from a team as a code owner August 9, 2023 08:45
@rubo rubo marked this pull request as draft August 23, 2023 20:24
@rubo rubo mentioned this pull request Aug 23, 2023
Merged
25 tasks
@rubo rubo marked this pull request as ready for review September 27, 2023 15:14
@kamilchodola kamilchodola merged commit 27a4807 into master Sep 28, 2023
181 checks passed
@kamilchodola kamilchodola deleted the feature/ppa-postinst-release branch September 28, 2023 21:00
kamilchodola pushed a commit that referenced this pull request Sep 28, 2023
@rubo @kamilchodola
Fix PPA package post-install script (#5991)
f02c690 
* Fix PPA post install script to download from the latest release branch

* Remove redundant space

* Update Nethermind executable name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilchodola kamilchodola kamilchodola approved these changes

@FalcoXYZ FalcoXYZ Awaiting requested review from FalcoXYZ

Assignees
No one assigned
Labels
devops needed in 1.21.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rubo @kamilchodola