Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify Nethermind executable name #5908

Merged
merged 7 commits into from
Jul 23, 2023
Merged

Unify Nethermind executable name #5908

merged 7 commits into from
Jul 23, 2023

Conversation

rubo
Copy link
Contributor

@rubo rubo commented Jul 6, 2023

Changes

This PR unifies the Nethermind executable name as now it's different depending on the installation source. For PPA and Homebrew, it's nethermind while for manual downloads it's Nethermind.Runner. The same issue is with the launcher and CLI.

  • Renamed the entrypoint assembly from Nethermind.Runner to nethermind
  • Renamed Nethermind.Cli to nethermind-cli
  • Renamed Nethermind.Launcher to nethermind-launcher
  • Updated existing scripts accordingly
  • Added Nethermind.Runner symlink for Linux packages to support the old naming for any existing setup

Before release

After release

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Needs manual testing.

Documentation

Requires documentation update

  • Yes
  • No

#5961

Requires explanation in Release Notes

  • Yes
  • No

The warning to include in all releases in the upcoming months:

⚠️ IMPORTANT

  • The Nethermind executable has been renamed from Nethermind.Runner to nethermind
  • The Nethermind launcher executable has been renamed from Nethermind.Launcher to nethermind-launcher
  • The Nethermind CLI executable has been renamed from Nethermind.Cli to nethermind-cli

Please update your setups accordingly if any.

After a few months, the above warning should be removed together with the symlinks.

@rubo rubo force-pushed the feature/unified-exec-name branch from 1352b8b to c957d4a Compare July 8, 2023 10:09
@rubo rubo force-pushed the feature/unified-exec-name branch from dc26a33 to b6d214c Compare July 23, 2023 19:47
@rubo rubo marked this pull request as ready for review July 23, 2023 20:17
@rubo rubo requested a review from a team as a code owner July 23, 2023 20:17
@rubo rubo merged commit 19b7eb4 into master Jul 23, 2023
61 checks passed
@rubo rubo deleted the feature/unified-exec-name branch July 23, 2023 20:21
qu0b added a commit to antithesishq/ethereum-testnet-bootstrapper that referenced this pull request Aug 4, 2023
qu0b added a commit to antithesishq/ethereum-testnet-bootstrapper that referenced this pull request Aug 4, 2023
@rubo rubo mentioned this pull request Aug 23, 2023
16 tasks
@kamilchodola kamilchodola restored the feature/unified-exec-name branch August 25, 2023 13:56
@kamilchodola kamilchodola deleted the feature/unified-exec-name branch August 28, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants