Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken links #100

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

fix: broken links #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a5719fb
fix: broken links
Ombuweb Sep 10, 2022
ec2492c
fix: broken link
Ombuweb Sep 10, 2022
f43dfdb
fix: broken link
Ombuweb Sep 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/mlkit-digital-ink-recognition.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ npm install @nativescript/mlkit-digital-ink-recognition

## Usage

See [@nativescript/mlkit-core](/packages/mlkit-core/README.md) Usage

See [@nativescript/mlkit-core](/plugins/mlkit-core.html#core) Usage
plugins/mlkit-core.html#core
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes will be overwritten from the plugins README, so would need to be made in the plugins repo instead.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am aware of that. You informed me about it when I made my first PR for a plugin. Thanks. Initially, I made these changes in the plugins' repo. However, when their READMEs were added to the main docs, the links broke(they only work on Github) because when you click on them from https://docs.nativescript.org/ they become https://docs.nativescript.org/packages/mlkit-core/README.html and since the packages folder is not in docs-new directory, they break. How can I make them work on both Github(when navigating from one README to another, within the same package) and https://docs.nativescript.org/?

## License

Apache License Version 2.0
2 changes: 1 addition & 1 deletion plugins/mlkit-face-detection.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ npm install @nativescript/mlkit-face-detection

## Usage

See [@nativescript/mlkit-core](/packages/mlkit-core/README.md) Usage
See [@nativescript/mlkit-core](/plugins/mlkit-core.html#usage) Usage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as previous


## License

Expand Down
Loading