-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: broken links #100
base: develop
Are you sure you want to change the base?
fix: broken links #100
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. |
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. |
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ui-and-styling
changes look OK, but the plugins ones will not be persisted, as they are overwritten daily form the plugins own README.md
See [@nativescript/mlkit-core](/packages/mlkit-core/README.md) Usage | ||
|
||
See [@nativescript/mlkit-core](/plugins/mlkit-core.html#core) Usage | ||
plugins/mlkit-core.html#core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes will be overwritten from the plugins README, so would need to be made in the plugins repo instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am aware of that. You informed me about it when I made my first PR for a plugin. Thanks. Initially, I made these changes in the plugins' repo. However, when their READMEs were added to the main docs, the links broke(they only work on Github) because when you click on them from https://docs.nativescript.org/
they become https://docs.nativescript.org/packages/mlkit-core/README.html
and since the packages
folder is not in docs-new
directory, they break. How can I make them work on both Github(when navigating from one README to another, within the same package) and https://docs.nativescript.org/
?
@@ -16,7 +16,7 @@ npm install @nativescript/mlkit-face-detection | |||
|
|||
## Usage | |||
|
|||
See [@nativescript/mlkit-core](/packages/mlkit-core/README.md) Usage | |||
See [@nativescript/mlkit-core](/plugins/mlkit-core.html#usage) Usage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as previous
I fixed the
/api-reference/xxx
links by removing.html
which I think causes the links to break. I did similar changes in PR #87 but think they shouldn't wait for that PR to be merged.