Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skosmos 3 docker: upgrade to Ubuntu 22.04 base image and PHP 8.1 #1498

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

osma
Copy link
Member

@osma osma commented Aug 30, 2023

Reasons for creating this PR

Skosmos 3 needs a recent PHP version (currently 8.0 or 8.1) but the Dockerfile we are using for running Skosmos is based on Ubuntu 20.04 which has PHP 7.4. This PR upgrades to a more recent Ubuntu 22.04 base image which has PHP 8.1.

Link to relevant issue(s), if any

  • prerequisite for properly running Cypress tests using dockerized Skosmos, e.g. Run cypress #1479

Description of the changes in this PR

  • upgrade to Ubuntu 22.04 base image
  • adjust system and PHP packages (gettext shouldn't be needed anymore)

Known problems or uncertainties in this PR

Not 100% sure if this is the right set of packages and PHP extensions, but we can fix that later if there are any problems.

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@osma osma added the maintenance Dependency changes, security updates, infrastructure tweaks & general mainenance label Aug 30, 2023
@osma osma added this to the 3.0 milestone Aug 30, 2023
@osma osma self-assigned this Aug 30, 2023
@osma osma requested a review from miguelvaara August 30, 2023 07:44
@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (cdcc15b) 63.89% compared to head (4eb7107) 63.89%.

Additional details and impacted files
@@             Coverage Diff              @@
##             skosmos-3    #1498   +/-   ##
============================================
  Coverage        63.89%   63.89%           
  Complexity        1634     1634           
============================================
  Files               32       32           
  Lines             4290     4290           
============================================
  Hits              2741     2741           
  Misses            1549     1549           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@osma osma merged commit e5c2ac2 into skosmos-3 Aug 31, 2023
7 of 10 checks passed
@osma osma deleted the skosmos-3-docker-ubuntu22.04 branch August 31, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Dependency changes, security updates, infrastructure tweaks & general mainenance
Projects
Status: Done (verified in test.dev.finto.fi, set Milestone 3.0 for both issue & PR)
Development

Successfully merging this pull request may close these issues.

1 participant