Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dockerized Skosmos for Cypress tests #1508

Closed
5 tasks done
osma opened this issue Aug 31, 2023 · 1 comment
Closed
5 tasks done

Use dockerized Skosmos for Cypress tests #1508

osma opened this issue Aug 31, 2023 · 1 comment
Assignees
Milestone

Comments

@osma
Copy link
Member

osma commented Aug 31, 2023

Description of the enhancement

We need a standardized Skosmos setup for running the Cypress tests. Currently this is a bit ad-hoc and every developer has their own Skosmos installations, which may have different configurations and vocabularies.

In #1488 / PR #1496, we are switching to a dockerized Fuseki for running the PHPUnit tests. In practice, this PR already uses docker compose to start up not just Fuseki but also a Skosmos container, even though it is not yet. The next logical step is to use that container for running Cypress tests.

Parts of this are already implemented or being worked on:

In addition to completing that work, these steps need to be done:

  • rename the init_fuseki.sh to something that covers Skosmos as well, e.g. init_containers.sh
  • adjust the Skosmos container so it uses the same configuration as for running PHPUnit tests
  • modify Cypress configuration so it uses the Skosmos container
  • adjust current Cypress tests so that they work with the test vocabularies we currently have
  • adjust documentation for running the tests (PHPUnit and Cypress) to correspond with the new situation

In the near future we probably need a new, larger and more diverse test vocabulary than the current very small ones, for example a cut down version of YSO, in order to make Cypress tests that test for advanced functionality. But that is outside the scope of this issue.

Who are the users that would benefit from the enhancement and how?

Mainly Skosmos developers.

What new functionalities would the enhancement make possible?

Running Cypress tests in a standardized environment. This also enables writing Cypress tests that are specific to a particular, known test vocabulary.

Why is the enhancement important?

This is a blocker for making substantial Cypress tests.

@osma osma added this to the 3.0 milestone Aug 31, 2023
@osma osma self-assigned this Aug 31, 2023
@osma
Copy link
Member Author

osma commented Sep 20, 2023

This was closed by merging #1509. For some reason the automation didn't work.

@osma osma closed this as completed Sep 20, 2023
@joelit joelit moved this to Done (verified in test.dev.finto.fi, set Milestone 3.0 for both issue & PR) in Skosmos 3.0 Backlog Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done (verified in test.dev.finto.fi, set Milestone 3.0 for both issue & PR)
Development

No branches or pull requests

1 participant