Add DLRM Model #1171
Merged
Add DLRM Model #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation preview |
marcromeyn
reviewed
Jul 3, 2023
| from merlin.schema import Schema | ||
|
|
||
|
|
||
| def DLRMModel( |
There was a problem hiding this comment.
I think it would be better to turn this into a class that extends Model. That would provide more flexibility to our users since they could extend it. In the past, I think we might have over-used using functions (would make sense if the output-type could differ).
marcromeyn
approved these changes
Jul 3, 2023
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
DLRMModelfunction that builds aModelusing theDLRMBlockadded in #1162.