Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match shape and dtype in loss calculation in pytorch backend #1156

Closed
wants to merge 8 commits into from
Closed

Match shape and dtype in loss calculation in pytorch backend #1156

wants to merge 8 commits into from

Conversation

edknv
Copy link
Contributor

@edknv edknv commented Jun 26, 2023

This PR uncomments a basic use case of training a model with TabularInputBlock using the Lightning trainer.

@edknv edknv added enhancement New feature or request area/pytorch labels Jun 26, 2023
@edknv edknv added this to the Merlin 23.07 milestone Jun 26, 2023
@edknv edknv self-assigned this Jun 26, 2023
@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/models/review/pr-1156

@edknv edknv requested a review from marcromeyn June 26, 2023 01:49
@edknv edknv marked this pull request as ready for review June 26, 2023 01:49
@edknv
Copy link
Contributor Author

edknv commented Jul 4, 2023

Redundant after #1171.

@edknv edknv closed this Jul 4, 2023
@edknv edknv deleted the torch/compute_loss_dtype branch July 4, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcromeyn marcromeyn Awaiting requested review from marcromeyn

Assignees

@edknv edknv

Labels
area/pytorch enhancement New feature or request
Projects
None yet
Milestone
Merlin 23.07
Development

Successfully merging this pull request may close these issues.
2 participants
@edknv @marcromeyn