Soiling algorithm updates Quyen's branch #432
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tio and fit multiple soiling rates per soiling interval (piecewise)) as well as CODS algorithm being added
…rials' into development
Signed-off-by: nmoyer <[email protected]>
Move SRR and CODS development branch from noromo01 to rdtools repo
…nto bare_except_error
qnguyen345
changed the base branch from
dev_SRR_CODS
to
aggregated_filters_for_trials
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## aggregated_filters_for_trials #432 +/- ##
=================================================================
+ Coverage 95.92% 96.04% +0.11%
=================================================================
Files 11 11
Lines 2209 2375 +166
=================================================================
+ Hits 2119 2281 +162
- Misses 90 94 +4 ☔ View full report in Codecov by Sentry. |
|
@mdeceglie - Quyen (@qnguyen345) finished the soiling PR. We haven't saved the 2 notebooks yet to give you a chance to look at the (minor) differences in the soiling results. |
mdeceglie
changed the base branch from
aggregated_filters_for_trials
to
development
mdeceglie
changed the title
|
Closing in favor of PR #435. |
martin-springer
changed the base branch from
development
to
qnguyen345-bare_except_error
martin-springer
changed the title
martin-springer
changed the base branch from
qnguyen345-bare_except_error
to
development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__init__.py