-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SRR and CODS updates #426
SRR and CODS updates #426
Conversation
…tio and fit multiple soiling rates per soiling interval (piecewise)) as well as CODS algorithm being added
…rials' into development
Signed-off-by: nmoyer <[email protected]>
Move SRR and CODS development branch from noromo01 to rdtools repo
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## aggregated_filters_for_trials #426 +/- ##
=================================================================
- Coverage 96.10% 95.68% -0.42%
=================================================================
Files 11 11
Lines 2206 2366 +160
=================================================================
+ Hits 2120 2264 +144
- Misses 86 102 +16 ☔ View full report in Codecov by Sentry. |
5d1f949
to
efa5042
Compare
@noromo01 - I tried to help with the soiling.py formatting. Not sure, if I made it better or worse tough... However, all of those can be fixed easily. I can take care of that, if you like? The only one that I need your input is the last exception in soiling.py (./rdtools/soiling.py:2944:5: E722 do not use bare 'except'). What exception would you like to catch there? |
@martin-springer I believe I fixed the formatting issues, everything looks good to me except for that bare except. I talked to Matt about that yesterday, we are working to find a solution to that. Someone else wrote that code so we are having some difficulty figuring out how to fix that |
@noromo01 - Got it. Thanks for fixing the formatting. It's looking good now. Please add your changes to the changelog under (docs\sphinx\source\changelog\pending.rst). @mdeceglie - Besides the one bare exception in soiling.py, this PR is ready for your review. |
@martin-springer @mdeceglie Matt and I are still working out some of the kinks with the notebook testing. We got everything to look good for method='half_norm_clean' but are still trying to make sure we don't change the functionality of Matt's new methods with piecewise and negative shift detection |
Closing in favor of #432 |
__init__.py