-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ResStock-HPXML: convert UpgradeCosts measure to ModelMeasure, try 2 #458
Conversation
Minimum allowed coverage is Generated by 🐒 cobertura-action against cc152d2 |
buildstockbatch/workflow_generator/residential/latest/__init__.py
Outdated
Show resolved
Hide resolved
"version": __version__, | ||
"version_description": """ | ||
Version information for the residential workflow generator. | ||
This version is compatible with ResStock v3.2.0 and later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not true, right? Compatible with ResStock > v3.2.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. Thanks for catching this.
@@ -1,8 +1,7 @@ | |||
# frozen_string_literal: true | |||
class Version | |||
ResStock_Version = '3.1.0' # Version of ResStock | |||
ResStock_Version = '2000.1.0' # Version of ResStock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test against the new WorkflowGenerator_Version
line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I forget why I made this change. ResStock_Version doesn't really matter for BuildStockBatch. We only care about "WorkflowGenerator_Version". I will address this.
docs/changelog/changelog_dev.rst
Outdated
.. change:: | ||
:tags: general, feature | ||
:pullreq: 458 | ||
|
||
For the Residential HPXML Workflow Generator, supports the UpgradeCosts measure | ||
changing from ReportingMeasure to ModelMeasure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably worth a much more comprehensive changelog entry than just this.
.github/workflows/ci.yml
Outdated
@@ -23,7 +23,7 @@ jobs: | |||
with: | |||
repository: NREL/resstock | |||
path: resstock | |||
ref: develop | |||
ref: res-reporting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before merge, need to switch this and down below back to develop (and make sure tests are still passing).
Pull Request Description
Supersedes #455.
Checklist
Not all may apply
minimum_coverage
in.github/workflows/coverage.yml
as necessary.