Convert UpgradeCosts measure to ModelMeasure #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
joseph-robertson
changed the title
joseph-robertson
changed the title
| @@ -487,12 +487,12 @@ def self.run(in_osw, parent_dir, run_output, upgrade, measures, reporting_measur | |||
| completed_at = out['completed_at'] | |||
| completed_status = out['completed_status'] | |||
|
|
|||
| results = File.join(parent_dir, 'run/results.json') | |||
| data_point_out = File.join(parent_dir, 'run/data_point_out.json') | |||
There was a problem hiding this comment.
There is no results.json when using the measures_only flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
UpgradeCosts does not need to be a reporting measure; it doesn't actually report any simulation output.
ReportHPXMLOutput does not need to be its own measure; it can be pulled into UpgradeCosts.
If UpgradeCosts becomes a model measure, it gets applied before simulation time and therefore its registered values would show up in the results.csv when using the
measures_onlyflag.This also fixes a bug related to using the
measure_onlyflag. When usingmeasure_only, theresults.jsonfile is not produced. Therefore, no registered values would show up in the results csv. Now we usedata_point_out.json, which is produced when usingmeasures_only.Update buildstock.rb and sample yml files with workflow generator version tag. This enables us to point to buildstockbatch's develop branch for CI tests.
Companion PR: NREL/buildstockbatch#458
Checklist
Not all may apply:
If related to resstock-estimation, checklist includes data dictionary, source report, options saturation, options_lookup.openstudio tasks.rb update_measureshas been run