Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #10665 - HeatPump:AirToWater:FuelFired:Heating was not using Outside air temperatures to evaluate curves #10681

Closed
wants to merge 2 commits into from
Closed

Fix #10665 - HeatPump:AirToWater:FuelFired:Heating was not using Outside air temperatures to evaluate curves #10681

wants to merge 2 commits into from

Commits on Aug 21, 2024

  1. Add a (failing) unit test for #10387 

    ```
[ RUN      ] EnergyPlusFixture.GAHP_AirSource_CurveEval
/home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc:5650: Failure
Expected equality of these values:
  oaTemp
    Which is: 3
  oaTempforCurve
    Which is: 43.0859
/home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc:5658: Failure
Expected equality of these values:
  oaTemp
    Which is: 3
  oaTempforCurve
    Which is: 43.0859
/home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc:5664: Failure
Expected equality of these values:
  oaTemp
    Which is: 3
  oaTempforCurve
    Which is: 3.33333
/home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc:5693: Failure
Expected equality of these values:
  oaTemp
    Which is: 3
  oaTempforCurve
    Which is: 43.0859
/home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc:5701: Failure
Expected equality of these values:
  oaTemp
    Which is: 3
  oaTempforCurve
    Which is: 43.0859
/home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc:5736: Failure
Expected equality of these values:
  oaWetbulb
    Which is: -4.36026
  oaTempforCurve
    Which is: 15.7288
/home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc:5744: Failure
Expected equality of these values:
  oaWetbulb
    Which is: -4.36026
  oaTempforCurve
    Which is: 15.7288
/home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc:5750: Failure
Expected equality of these values:
  oaWetbulb
    Which is: -4.36026
  oaTempforCurve
    Which is: 3.33333
/home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc:5778: Failure
Expected equality of these values:
  oaWetbulb
    Which is: -4.36026
  oaTempforCurve
    Which is: 17.0828
/home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc:5786: Failure
Expected equality of these values:
  oaWetbulb
    Which is: -4.36026
  oaTempforCurve
    Which is: 17.0828
[  FAILED  ] EnergyPlusFixture.GAHP_AirSource_CurveEval (900 ms)
```
    @jmarrec
    jmarrec committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    8c89051 View commit details
    Browse the repository at this point in the history

  2. Fix #10387 - HeatPump:AirToWater:FuelFired:Heating was not using Outs… 

    …ide air temperatures to evaluate curves
    @jmarrec
    jmarrec committed Aug 21, 2024
    1 Configuration menu
    Copy the full SHA
    3fe7397 View commit details
    Browse the repository at this point in the history