Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #10665 - HeatPump:AirToWater:FuelFired:Heating was not using Outside air temperatures to evaluate curves #10681

Closed
wants to merge 2 commits into from
Closed

Fix #10665 - HeatPump:AirToWater:FuelFired:Heating was not using Outside air temperatures to evaluate curves #10681

wants to merge 2 commits into from

Conversation

jmarrec
Copy link
Contributor

@jmarrec jmarrec commented Aug 21, 2024 •
edited
Loading

Pull request overview

Using PlantLoopHeatPump_Fuel-Fired.idf , before versus after, plotting the CAPCURVEFUNCTEMP2

image

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@jmarrec
Add a (failing) unit test for #10387
8c89051 
```
[ RUN      ] EnergyPlusFixture.GAHP_AirSource_CurveEval
/home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc:5650: Failure
Expected equality of these values:
  oaTemp
    Which is: 3
  oaTempforCurve
    Which is: 43.0859
/home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc:5658: Failure
Expected equality of these values:
  oaTemp
    Which is: 3
  oaTempforCurve
    Which is: 43.0859
/home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc:5664: Failure
Expected equality of these values:
  oaTemp
    Which is: 3
  oaTempforCurve
    Which is: 3.33333
/home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc:5693: Failure
Expected equality of these values:
  oaTemp
    Which is: 3
  oaTempforCurve
    Which is: 43.0859
/home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc:5701: Failure
Expected equality of these values:
  oaTemp
    Which is: 3
  oaTempforCurve
    Which is: 43.0859
/home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc:5736: Failure
Expected equality of these values:
  oaWetbulb
    Which is: -4.36026
  oaTempforCurve
    Which is: 15.7288
/home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc:5744: Failure
Expected equality of these values:
  oaWetbulb
    Which is: -4.36026
  oaTempforCurve
    Which is: 15.7288
/home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc:5750: Failure
Expected equality of these values:
  oaWetbulb
    Which is: -4.36026
  oaTempforCurve
    Which is: 3.33333
/home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc:5778: Failure
Expected equality of these values:
  oaWetbulb
    Which is: -4.36026
  oaTempforCurve
    Which is: 17.0828
/home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc:5786: Failure
Expected equality of these values:
  oaWetbulb
    Which is: -4.36026
  oaTempforCurve
    Which is: 17.0828
[  FAILED  ] EnergyPlusFixture.GAHP_AirSource_CurveEval (900 ms)
```
@jmarrec
Fix #10387 - HeatPump:AirToWater:FuelFired:Heating was not using Outs…
3fe7397 
…ide air temperatures to evaluate curves
@jmarrec jmarrec added the Defect Includes code to repair a defect in EnergyPlus label Aug 21, 2024
@jmarrec jmarrec self-assigned this Aug 21, 2024
@jmarrec
Copy link
Contributor Author

jmarrec commented Aug 21, 2024 •
edited
Loading

Now, I change the evaluation variables

image

image

@shorowit
Copy link
Contributor

@jmarrec This fixes #10665, not #10387, right?

@jmarrec jmarrec changed the title Fix #10387 - HeatPump:AirToWater:FuelFired:Heating was not using Outside air temperatures to evaluate curves Fix #10665 - HeatPump:AirToWater:FuelFired:Heating was not using Outside air temperatures to evaluate curves Aug 21, 2024
@jmarrec
Copy link
Contributor Author

jmarrec commented Aug 21, 2024

@jmarrec This fixes #10665, not #10387, right?

🤦‍♂️ yes, thank you.

@jmarrec jmarrec added the NotIDDChange Code does not impact IDD (can be merged after IO freeze) label Aug 21, 2024
@jmarrec jmarrec closed this Aug 21, 2024
@jmarrec jmarrec deleted the 10387_EIRPLHP_PowerUsage branch August 21, 2024 17:15
@jmarrec
Copy link
Contributor Author

jmarrec commented Aug 21, 2024

Redone in #10682, apologies

@jmarrec jmarrec removed the request for review from Myoldmopar August 21, 2024 17:18
@jmarrec jmarrec removed Defect Includes code to repair a defect in EnergyPlus NotIDDChange Code does not impact IDD (can be merged after IO freeze) labels Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jmarrec jmarrec

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HeatPump:AirToWater:FuelFired:Heating curves not using two independent temperature variables
3 participants
@jmarrec @shorowit @nrel-bot