-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix VRF FluidTCtrl negative outdoor unit fan power #10649
Open
yujiex
wants to merge
20
commits into
develop
Choose a base branch
from
fixVRFnegativeFanPower
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
7f2acaf
use abs(QCoil) in air flow calculation
ae3fec6
Merge remote-tracking branch 'origin/develop' into fixVRFnegativeFanP…
cabd9e6
revert abs(Q_coil), reduce h_IU_cond_in label230, fix Q_evap_req neg
765218b
Merge remote-tracking branch 'origin/develop' into fixVRFnegativeFanP…
35d4b69
add converge check that h_comp_out_new changed
0f1d4fd
Merge remote-tracking branch 'origin/develop' into fixVRFnegativeFanP…
935df9e
Revert "add converge check that h_comp_out_new changed"
38ad9f1
Patch for Q_cond_req < min speed power, CompSpdActual int to real
d54f356
clang-format
39567c8
fix unit test
aae3346
simplify the code by condition on sign of Q_evap_req
bd53fd7
Merge remote-tracking branch 'origin/develop' into fixVRFnegativeFanP…
4e979ea
use PLR in compressor speed calculation
1b58521
modify PLR application on the speed level > 1 case
cce66e0
Merge remote-tracking branch 'origin/develop' into fixVRFnegativeFanP…
a135044
fix unit test after changing compSpdActual calculation
835253a
remove unused Q_evap_req, remove C_cap_operation adjustment
436f277
fix unit test after removing C_cap_operation adjustment
a777bf5
fix uninitialized RatedHeatCapacity in VRF HR model
380d580
use newly derived r to compute compressor speed and Q_evap_req
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yujiex I think I understand the intent here. This could be simpler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, this is more clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I don't understand is what looks like a COP term = Qc / PWR. I just don't see how that gets back to a speed 1 fraction. What am I missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rraustad The way I think about this is when
Q_cond_req - CompEvaporatingPWRSpd(1) <= 0.0
, then whatCompEvaporatingPWRSpd(1)
can supply is too much to meetQ_cond_req
. The speed should be somewhere between 0 and the 1st speed level. So in this caseQ_cond_req
should be met byCompEvaporatingPWRSpd(1) * ratio
. Thisratio
is calculated asQ_cond_req / CompEvaporatingPWRSpd(1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But CompEvaporatingPWRSpd is power, not capacity. So
Q_cond_req / CompEvaporatingPWRSpd(1)
looks strange to me. Shouldn't both equations have CompEvaporatingCAPSpd in the denominator (line 13729)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can also try to change the VRF evaporative capacity to make it reach higher speed levels.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is how they look when they can reach higher speed levels (I reduced the capacity to 10000, the autosized heating and cooing capacity are around 70000W)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make it span speeds? like from speed 1 to speed 3? I want to see what Q_evap_req * C_cap_operating / CompEvaporatingCAPSpd(x) looks like (or your derivation). I suspect there are discontinuities because C_cap_operatiion = 0.6. And make a scatter plot like before. Q_evap_req versus compressor speed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see, your plot is Q_evap_req versus comp speed. I was confused because I didn't see a 45 degree line like I was expecting. Why is Q_evap_req = 2000 at comp speeds 0 - 10000 ??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somehow there's some weird thing happening when I plot with excel. CompSpdActual is always below 6000 for both the feature and develop branch output, but it somehow plotted it out to over 10000. I have attached the data here
plot data.zip
I used R to plot, this is how they look