-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix VRF FluidTCtrl negative outdoor unit fan power #10649
base: develop
Are you sure you want to change the base?
Commits on Aug 8, 2024
-
use abs(QCoil) in air flow calculation
as QCoil is negative in cooling mode, directly using m_air = Q_coil / (T_coil_out - T_coil_in) / 1005.0 will result in negative air flow, as well as downstream fan power Here QCoil should be abs(QCoil)
Yujie Xu committedAug 8, 2024 5Configuration menu - View commit details
-
Copy full SHA for 7f2acaf - Browse repository at this point
Copy the full SHA 7f2acafView commit details
Commits on Aug 13, 2024
-
Merge remote-tracking branch 'origin/develop' into fixVRFnegativeFanP…
…ower
Yujie Xu committedAug 13, 2024 5Configuration menu - View commit details
-
Copy full SHA for ae3fec6 - Browse repository at this point
Copy the full SHA ae3fec6View commit details
Commits on Aug 22, 2024
-
revert abs(Q_coil), reduce h_IU_cond_in label230, fix Q_evap_req neg
per Mike's comment, #10649 (comment), Q_coil should not be negative, remove the abs(Q_coil) fix Q_evap_req will be negative if Q_cond_req < CompEvaporatingPWRSpd(CounterCompSpdTemp). This leads to negative compressor speed. Temtatively fix it like this. According to comment here #10649 (comment), The h_comp_out and h_comp_out_new could keep getting farther and farther from each other if h_cond_IU_in can only increase in the iteration. Addressing this by adding a direction where h_cond_IU can decrease as well.
Yujie Xu committedAug 22, 2024 4Configuration menu - View commit details
-
Copy full SHA for cabd9e6 - Browse repository at this point
Copy the full SHA cabd9e6View commit details
Commits on Aug 23, 2024
-
Merge remote-tracking branch 'origin/develop' into fixVRFnegativeFanP…
…ower
Yujie Xu committedAug 23, 2024 4Configuration menu - View commit details
-
Copy full SHA for 765218b - Browse repository at this point
Copy the full SHA 765218bView commit details -
add converge check that h_comp_out_new changed
Yujie Xu committedAug 23, 2024 8Configuration menu - View commit details
-
Copy full SHA for 35d4b69 - Browse repository at this point
Copy the full SHA 35d4b69View commit details
Commits on Oct 4, 2024
-
Merge remote-tracking branch 'origin/develop' into fixVRFnegativeFanP…
…ower
Yujie Xu committedOct 4, 2024 Configuration menu - View commit details
-
Copy full SHA for 0f1d4fd - Browse repository at this point
Copy the full SHA 0f1d4fdView commit details
Commits on Oct 7, 2024
-
Revert "add converge check that h_comp_out_new changed"
This reverts commit 35d4b69.
Yujie Xu committedOct 7, 2024 Configuration menu - View commit details
-
Copy full SHA for 935df9e - Browse repository at this point
Copy the full SHA 935df9eView commit details -
Patch for Q_cond_req < min speed power, CompSpdActual int to real
When Q_cond_req < ComoEvaporatingPWRSpd(1), Q_evap_req will be negative, the calculated compressor speed will be negative. The case where Q_cond_req < ComoEvaporatingPWRSpd(1) need to be considered, where compressor speed is dependent on the compressour power curve output value. CompSpdActual argument VRFOU_CompCap is an int, but the value passed in was originally a real. This casting from int to real will truncate the value. If the value is less than 1, it will be set to 0.
Yujie Xu committedOct 7, 2024 Configuration menu - View commit details
-
Copy full SHA for 38ad9f1 - Browse repository at this point
Copy the full SHA 38ad9f1View commit details -
Yujie Xu committed
Oct 7, 2024 4Configuration menu - View commit details
-
Copy full SHA for d54f356 - Browse repository at this point
Copy the full SHA d54f356View commit details -
Yujie Xu committed
Oct 7, 2024 4Configuration menu - View commit details
-
Copy full SHA for 39567c8 - Browse repository at this point
Copy the full SHA 39567c8View commit details
Commits on Oct 14, 2024
-
simplify the code by condition on sign of Q_evap_req
Yujie Xu committedOct 14, 2024 Configuration menu - View commit details
-
Copy full SHA for aae3346 - Browse repository at this point
Copy the full SHA aae3346View commit details -
Merge remote-tracking branch 'origin/develop' into fixVRFnegativeFanP…
…ower
Yujie Xu committedOct 14, 2024 4Configuration menu - View commit details
-
Copy full SHA for bd53fd7 - Browse repository at this point
Copy the full SHA bd53fd7View commit details
Commits on Oct 21, 2024
-
use PLR in compressor speed calculation
Yujie Xu committedOct 21, 2024 4Configuration menu - View commit details
-
Copy full SHA for 4e979ea - Browse repository at this point
Copy the full SHA 4e979eaView commit details -
modify PLR application on the speed level > 1 case
Yujie Xu committedOct 21, 2024 Configuration menu - View commit details
-
Copy full SHA for 1b58521 - Browse repository at this point
Copy the full SHA 1b58521View commit details -
Merge remote-tracking branch 'origin/develop' into fixVRFnegativeFanP…
…ower
Yujie Xu committedOct 21, 2024 4Configuration menu - View commit details
-
Copy full SHA for cce66e0 - Browse repository at this point
Copy the full SHA cce66e0View commit details -
fix unit test after changing compSpdActual calculation
Yujie Xu committedOct 21, 2024 Configuration menu - View commit details
-
Copy full SHA for a135044 - Browse repository at this point
Copy the full SHA a135044View commit details
Commits on Oct 22, 2024
-
remove unused Q_evap_req, remove C_cap_operation adjustment
C_cap_operation was used in the evaporative load adjsutment but not power. not sure if this is intended. Maybe just remove this for now Q_evap_req is no longer used in the calculation, remove it
Yujie Xu committedOct 22, 2024 Configuration menu - View commit details
-
Copy full SHA for 835253a - Browse repository at this point
Copy the full SHA 835253aView commit details -
fix unit test after removing C_cap_operation adjustment
Yujie Xu committedOct 22, 2024 Configuration menu - View commit details
-
Copy full SHA for 436f277 - Browse repository at this point
Copy the full SHA 436f277View commit details
Commits on Oct 23, 2024
-
fix uninitialized RatedHeatCapacity in VRF HR model
Yujie Xu committedOct 23, 2024 Configuration menu - View commit details
-
Copy full SHA for a777bf5 - Browse repository at this point
Copy the full SHA a777bf5View commit details
Commits on Oct 24, 2024
-
use newly derived r to compute compressor speed and Q_evap_req
how r is derived: in the original code Q_evap_req = Q_cond_req - CompEvaporatingPWRSpd(CounterCompSpdTemp); I think the intent was Q_cond_req = Q_req = Q_evap_req + compressor heat but compressor heat might not actually be CompEvaporatingPWRSpd(CounterCompSpdTemp) let k be the speed level C be the short form for C_cap_operation PWR(.) be the short form of CompEvaporatingPWRSpd(.) CAP(.) be the short form of CompEvaporatingCAPSpd(.) spd(.) be the short form of this->CompressorSpeed(.) deltaPWR be PWR(k) - PWR(k - 1) deltaCAP be CAP(k) - CAP(k - 1) I think compressor heat should be this instead of just PWR(k) compressor heat = deltaPWR * r + PWR(k - 1) so Q_cond_req = Q_req = Q_evap_req + deltaPWR * r + PWR(k - 1) <---- eq 1 we also know this from the CompSpdActual calculation equation that CompSpdActual = Spd(k - 1) + deltaSpd / deltaCAP * (Q_evap_req * C - CAP(k - 1)) so we call the following r r = (Q_evap_req * C - CAP(k - 1)) / deltaCAP so CompSpdActual = Spd(k - 1) + deltaSpd * r arranging terms in eq 1 Q_cond_req - deltaPWR * r - PWR(k - 1) = Q_evap_req (Q_cond_req - deltaPWR * r - PWR(k - 1)) * C - CAP(k - 1) = Q_evap_req * C - CAP(k - 1) ((Q_cond_req - deltaPWR * r - PWR(k - 1)) * C - CAP(k - 1)) / deltaCAP = (Q_evap_req * C - CAP(k - 1)) / deltaCAP ((Q_cond_req - deltaPWR * r - PWR(k - 1)) * C - CAP(k - 1)) / deltaCAP = r (Q_cond_req - deltaPWR * r - PWR(k - 1)) * C - CAP(k - 1) = deltaCAP * r (Q_cond_req - PWR(k - 1)) * C - CAP(k - 1) = deltaCAP * r + deltaPWR * r * C so r = ((Q_cond_req - PWR(k - 1)) * C - CAP(k - 1)) / (deltaCAP + deltaPWR * C) = ((Q_cond_req - PWR(k - 1)) - CAP(k - 1)/C) / (deltaCAP/C + deltaPWR) in the special case where k = 1, then k - 1, PWR(k - 1) and CAP(k - 1) will all be 0 r = ((Q_cond_req) * C) / (CAP(1) + PWR(1) * C) = (Q_cond_req) / (CAP(1)/C + PWR(1))
Yujie Xu committedOct 24, 2024 4Configuration menu - View commit details
-
Copy full SHA for 380d580 - Browse repository at this point
Copy the full SHA 380d580View commit details