-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jd/multiple fixes #1145
base: main
Are you sure you want to change the base?
Jd/multiple fixes #1145
Conversation
…rSimulations.jl into jd/multiple_fixes
Performance Results
|
Rh/fix compact marketbid
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1145 +/- ##
==========================================
+ Coverage 77.89% 78.44% +0.55%
==========================================
Files 118 121 +3
Lines 12700 12793 +93
==========================================
+ Hits 9893 10036 +143
+ Misses 2807 2757 -50
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm concerned about this add to expression with must run are working properly without testing. Did we QA/QC those ones?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. I have one major concern regarding the testing of the add to expression when must run is on, and I'm not exactly sure where the fix of the On variable happens now.
@rodrigomha I have to add a test for that case to and fix StorageSystemsSimulations.jl |
fixes #1133
fixes #1140
fixes #1129
fixes #1116
fixes #1148
fixes #1151