Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ambiguity #36

Merged
merged 1 commit into from
Sep 27, 2024
Merged

fix ambiguity #36

merged 1 commit into from
Sep 27, 2024

Conversation

jd-lara
Copy link
Member

@jd-lara jd-lara commented Sep 25, 2024

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.61%. Comparing base (3eb2033) to head (cb5c8b2).
Report is 26 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   87.54%   87.61%   +0.07%     
==========================================
  Files           9       10       +1     
  Lines         859      864       +5     
==========================================
+ Hits          752      757       +5     
  Misses        107      107              
Flag Coverage Δ
unittests 87.61% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/feedforwards.jl 92.38% <ø> (ø)

... and 1 file with indirect coverage changes

@pesap
Copy link
Collaborator

pesap commented Sep 26, 2024

I dont know why the windows test is failing. I tried re-running and still fails. Do you have any insgihts?

@jd-lara
Copy link
Member Author

jd-lara commented Sep 26, 2024

I dont know why the windows test is failing. I tried re-running and still fails. Do you have any insgihts?

It seems to be an Ipopt binary issue.

@jd-lara jd-lara merged commit 4f9bf11 into main Sep 27, 2024
7 of 8 checks passed
@jd-lara jd-lara deleted the jd/implemente_new_parameter_update branch September 27, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants