Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linting to CI #284

Merged
merged 19 commits into from
Jan 8, 2024
Merged

Add linting to CI #284

merged 19 commits into from
Jan 8, 2024

Commits on Dec 21, 2023

  1. Add linting to CI

    ian-noaa committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    eea74b7 View commit details
    Browse the repository at this point in the history
  2. Remove pylint disable comments from src

    Now that we're using Ruff, these don't apply anyways.
    ian-noaa committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    a1bc5c6 View commit details
    Browse the repository at this point in the history
  3. Fix all Flake8 rules

    ian-noaa committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    5cd6c19 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1d4ffb3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d15de3c View commit details
    Browse the repository at this point in the history
  6. Update linter config

    ian-noaa committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    fb11d22 View commit details
    Browse the repository at this point in the history
  7. Remove pylint disable comments from tests

    Now that we're using Ruff, these don't apply anyways.
    ian-noaa committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    f6fb395 View commit details
    Browse the repository at this point in the history
  8. Format tests

    ian-noaa committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    aa25cc7 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2023

  1. Switch to pathlib where possible

    Additionally, use the tmp_path pytest fixture in place of hardcoded
    paths where possible.
    ian-noaa committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    035d965 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d689c1a View commit details
    Browse the repository at this point in the history
  3. Finish switching the test suite to pathlib

    In some cases, I had to explicitly cast the pathlib.glob() expressions
    to lists so that len() would work on them. Pathlib.glob returns a
    generator expression instead of a list like glob.glob().
    ian-noaa committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    33d8f0e View commit details
    Browse the repository at this point in the history
  4. Fix all linter issues found by flake8-pytest-style

    Mostly, removing some extra try/except statements. Pytest will handle
    these for us and automatically fail the test if it throws an exception
    ian-noaa committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    2c20dac View commit details
    Browse the repository at this point in the history
  5. Fix bugbear linter rules

    The try/except in connect_cb() was always being triggered as
    cb_connection was never defined.
    ian-noaa committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    e4047fd View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    063ca67 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2024

  1. Configuration menu
    Copy the full SHA
    e047d5f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    efa775a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6fafbf5 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. Configuration menu
    Copy the full SHA
    5cd2173 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9475a04 View commit details
    Browse the repository at this point in the history