-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linting to CI #284
Add linting to CI #284
Commits on Dec 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for eea74b7 - Browse repository at this point
Copy the full SHA eea74b7View commit details -
Remove pylint disable comments from src
Now that we're using Ruff, these don't apply anyways.
Configuration menu - View commit details
-
Copy full SHA for a1bc5c6 - Browse repository at this point
Copy the full SHA a1bc5c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5cd6c19 - Browse repository at this point
Copy the full SHA 5cd6c19View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d4ffb3 - Browse repository at this point
Copy the full SHA 1d4ffb3View commit details -
Configuration menu - View commit details
-
Copy full SHA for d15de3c - Browse repository at this point
Copy the full SHA d15de3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for fb11d22 - Browse repository at this point
Copy the full SHA fb11d22View commit details -
Remove pylint disable comments from tests
Now that we're using Ruff, these don't apply anyways.
Configuration menu - View commit details
-
Copy full SHA for f6fb395 - Browse repository at this point
Copy the full SHA f6fb395View commit details -
Configuration menu - View commit details
-
Copy full SHA for aa25cc7 - Browse repository at this point
Copy the full SHA aa25cc7View commit details
Commits on Dec 29, 2023
-
Switch to pathlib where possible
Additionally, use the tmp_path pytest fixture in place of hardcoded paths where possible.
Configuration menu - View commit details
-
Copy full SHA for 035d965 - Browse repository at this point
Copy the full SHA 035d965View commit details -
Configuration menu - View commit details
-
Copy full SHA for d689c1a - Browse repository at this point
Copy the full SHA d689c1aView commit details -
Finish switching the test suite to pathlib
In some cases, I had to explicitly cast the pathlib.glob() expressions to lists so that len() would work on them. Pathlib.glob returns a generator expression instead of a list like glob.glob().
Configuration menu - View commit details
-
Copy full SHA for 33d8f0e - Browse repository at this point
Copy the full SHA 33d8f0eView commit details -
Fix all linter issues found by flake8-pytest-style
Mostly, removing some extra try/except statements. Pytest will handle these for us and automatically fail the test if it throws an exception
Configuration menu - View commit details
-
Copy full SHA for 2c20dac - Browse repository at this point
Copy the full SHA 2c20dacView commit details -
The try/except in connect_cb() was always being triggered as cb_connection was never defined.
Configuration menu - View commit details
-
Copy full SHA for e4047fd - Browse repository at this point
Copy the full SHA e4047fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 063ca67 - Browse repository at this point
Copy the full SHA 063ca67View commit details
Commits on Jan 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e047d5f - Browse repository at this point
Copy the full SHA e047d5fView commit details -
Configuration menu - View commit details
-
Copy full SHA for efa775a - Browse repository at this point
Copy the full SHA efa775aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6fafbf5 - Browse repository at this point
Copy the full SHA 6fafbf5View commit details
Commits on Jan 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5cd2173 - Browse repository at this point
Copy the full SHA 5cd2173View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9475a04 - Browse repository at this point
Copy the full SHA 9475a04View commit details