Add linting to CI #284
Merged
Add linting to CI #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we're using Ruff, these don't apply anyways.
Now that we're using Ruff, these don't apply anyways.
Additionally, use the tmp_path pytest fixture in place of hardcoded paths where possible.
In some cases, I had to explicitly cast the pathlib.glob() expressions to lists so that len() would work on them. Pathlib.glob returns a generator expression instead of a list like glob.glob().
Mostly, removing some extra try/except statements. Pytest will handle these for us and automatically fail the test if it throws an exception
The try/except in connect_cb() was always being triggered as cb_connection was never defined.
Closed
4 tasks
randytpierce
approved these changes
Jan 5, 2024
|
Hopefully this means we won't have to add any more of those disable statements! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change: