Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submodule pointer update for ccpp-framework PR 600 (bug fix for unit conversion error in ccpp_prebuild.py ) #878

Closed

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Oct 11, 2024

Description

This PR updates the submodule pointer for ccpp-framework for the changes described in NCAR/ccpp-framework#600 (Bug fix for unit conversion error in ccpp_prebuild.py (variables that are slices of a n+1 dimensional array have wrong allocation). The bug that is being fixed did not affect the UFS Weather Model, hence there are no answer changes associated with this update.

Issue(s) addressed

Resolves NCAR/ccpp-framework#598

Testing

See ufs-community/ufs-weather-model#2464 (ufs-weather-model regression tests passed against exising baseline on Hera).

Dependencies

Requirements before merging

  • All new code in this PR is tested by at least one unit test
  • All new code in this PR includes Doxygen documentation
  • All new code in this PR does not add new compilation warnings (check CI output)

@climbfuji
Copy link
Collaborator Author

@DusanJovic-NOAA This won't be needed because you are pointing to my ccpp-framework branch, correct?

@climbfuji
Copy link
Collaborator Author

This PR isn't needed, @DusanJovic-NOAA 's fv3atm PR took care of updating the ccpp-framework submodule pointer

@climbfuji climbfuji closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant