Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop]: Documentation updates + Submodule pointer update (fv3atm, ccpp-framework) for ccpp-framework PR 600 (bug fix for unit conversion error in ccpp_prebuild.py ) #2464 + Update chunksizes for cubed sphere grid #2465 #2463

Merged
merged 19 commits into from
Oct 23, 2024

Conversation

gspetro-NOAA
Copy link
Contributor

@gspetro-NOAA gspetro-NOAA commented Oct 10, 2024

Description:

This PR updates to the Input/Output chapter of the documentation to include info on fd_ufs.yaml and to update the land-related sections.
This PR also generates documentation from the docstrings in the tests-dev Python scripts.
You can view the docs in my fork here: https://gsp-wm.readthedocs.io/en/text-landda/

Commit Message:

* UFSWM - 
  Update LND I/O docs
  Add fd_ufs.yaml docs
  Add tests-dev docs
* UFSWM - Change the default chunking for the cubed sphere history files to use only the horizontal grid size of each of the tiles.
   * FV3 - Change the default chunking for the cubed sphere history files to use only the horizontal grid size of each of the tiles.
   * FV3 - Submodule pointer update for ccpp-framework PR 600 (bug fix for unit conversion error in ccpp_prebuild.py)

Priority:

  • High: Hoping to get changes in ahead of Land DA v2.0.0 release

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • No Baseline Changes.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn skipped due to machine maintenance
  • CI
  • opnReqTest (complete task if unnecessary)

@gspetro-NOAA
Copy link
Contributor Author

gspetro-NOAA commented Oct 11, 2024

Note that I have toggled on the functionality to build docs for every PR.
If you click on "Details" after the docs/readthedocs.org:ufs-weather-model check at the bottom of the PR, you will either see the PR docs, the build progress (if it hasn't completed), or the traceback (if it fails). I believe that after 90 days, the build is deleted, so the docs are not stored indefinitely, but this will ensure that there are no obvious issues with the PR docs.

It is possible to turn on a "warn as error" functionality in the docs that will fail the build check when warnings appear (rather than just failing for errors). Let me know if you'd like me to turn on this functionality. It has the benefit of catching small issues as they occur (such as changes to URLs in the docs), which is helpful for maintenance. However, developers may not like having to fix issues like this that are outside their PR scope, even if they are usually small/simple fixes. That said, I'm happy to work with them to put the fixes into their PR or a subsequent PR if such issues occur.

@jkbk2004
Copy link
Collaborator

@gspetro-NOAA can you sync up branch? I will try to combine in #2465.

@jkbk2004 jkbk2004 added No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. labels Oct 20, 2024
@jkbk2004 jkbk2004 changed the title [develop]: Documentation updates [develop]: Documentation updates + Submodule pointer update (fv3atm, ccpp-framework) for ccpp-framework PR 600 (bug fix for unit conversion error in ccpp_prebuild.py ) #2464 + Update chunksizes for cubed sphere grid #2465 Oct 21, 2024
@FernandoAndrade-NOAA FernandoAndrade-NOAA added jenkins-ort run ORT testing and removed jenkins-ort run ORT testing labels Oct 21, 2024
@jkbk2004
Copy link
Collaborator

Jobs on Jet are still not moving. Note that baseline is restored and available at /lfs5/HFIP/hfv3gfs/role.epic/RT/NEMSfv3gfs/develop-20241011. We need to skip Jet.

@FernandoAndrade-NOAA
Copy link
Collaborator

@jkbk2004 FYI Derecho is having persistent timeout issues with the s2swa_faster_intel compile

@jkbk2004
Copy link
Collaborator

We can start merging process for this pr. We will follow the Derecho issue with #2479. @ulmononian @RatkoVasic-NOAA FYI

@jkbk2004 jkbk2004 merged commit be4544e into ufs-community:develop Oct 23, 2024
4 checks passed
tsga added a commit to tsga/ufs-weather-model that referenced this pull request Oct 30, 2024
* develop:
  [develop]: Documentation updates + Submodule pointer update (fv3atm, ccpp-framework) for ccpp-framework PR 600 (bug fix for unit conversion error in ccpp_prebuild.py ) ufs-community#2464 + Update chunksizes for cubed sphere grid ufs-community#2465 (ufs-community#2463)
  First reconciliation PR from production/RRFS.v1 (ufs-community#2449)
  Add GFDL Land Model 4.0  (ufs-community#2146)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update WM Documentation writing native grid atmf history files is too slow in FV3ATM
6 participants