Bug fix for physics suites using C3 or SAS convection with MYNN PBL scheme #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
|
Please specify the ccpp-physics PR that this PR depends on. |
done |
|
@jkbk2004 @lisa-bengtsson This can be closed since it is combined into #865 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: ufs-community/ufs-weather-model#2342
When running physics suites using C3 or SAS convection with the prognostic area fraction closure, and MYNN PBL, there is a bug in that the convection expects the field "tendency_of_vertically_diffused_tracer_concentration", to compute the turbulent moisture flux component of the total moisture convergence term, that is output from all PBL schemes except MYNN.
This PR updates the submodule pointer to ccpp/physics which adds "tendency_of_vertically_diffused_tracer_concentration" as output from the MYNN PBL scheme
Addresses CCPP PR:
ufs-community/ccpp-physics#218