-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix for physics suites using C3 or SAS convection with MYNN PBL scheme #2344
Conversation
@lisa-bengtsson Do you know if this is expected to change baselines? |
Yes, I believe to some of the tests that include the combination of C3 and MYNN, or SAS and MYNN. I will run the RT tests over the weekend and let you know. Thanks! |
@grantfirl turns out none of the RT's are impacted by this change. The global nest v1 tests (*gnv1) are not impacted because the prognostic closure in convection is not used at C96 resolution. And there doesn't seem to be a test for the RRFS ensemble configurations using SAS+MYNN. In the future it may be good to add additional regional test for those configs I think. I have uploaded the log file from Hera Intel and gnu, and will change the description that no new baselines are needed. |
@lisa-bengtsson @jkbk2004 This can be closed since it was combined into #2408. |
merged with #2408 |
Commit Queue Requirements:
Description:
When running physics suites using C3 or SAS convection with the prognostic area fraction closure, and MYNN PBL, there is a bug in that the convection expects the field "tendency_of_vertically_diffused_tracer_concentration", to compute the turbulent moisture flux component of the total moisture convergence term, that is output from all PBL schemes except MYNN.
This PR updates the submodule pointer to FV3 and ccpp/physics which adds "tendency_of_vertically_diffused_tracer_concentration" as output from the MYNN PBL scheme
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
Library Changes/Upgrades:
Testing Log: