-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scientific documentation for CCPP-SCM v7.0.0 #1077
Merged
Merged
Changes from 23 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
d827f4c
initiate SciDoc for CCPP-SCM v7
mzhangw 8f6cbf6
save the changes
2903b95
Merge branch 'main' of https://github.com/NCAR/ccpp-physics into scid…
7a0c400
save scidoc v7 progress
283be49
save work progress
1be281d
save progress
mzhangw 8525a7e
save scidoc
mzhangw 9b53b71
code cleanup
mzhangw 0e86a0a
save scidoc progress
mzhangw fe9b68d
address developer's feedback
mzhangw c9e5f21
scidoc update
mzhangw 0b64057
add seperate page for cellular automata and physics update summary
mzhangw 8ca1374
scidoc updates
mzhangw 29cf6e2
Merge branch 'main' of https://github.com/NCAR/ccpp-physics into scid…
mzhangw 58d9673
finalize the suite names
mzhangw c6da115
address Ligia's review
mzhangw 4ac4123
continue addressing reviews
mzhangw 4355f69
more tweaks
mzhangw 59040c2
scidoc updates
mzhangw 95bad43
Merge branch 'main' of https://github.com/NCAR/ccpp-physics into scid…
mzhangw 1dff883
implement S. Hong's modification
mzhangw b62597b
address review and fix bugs
mzhangw 6d98b1e
address Scidoc reviews
mzhangw 36abac9
scidoc updates
mzhangw cca1cf8
Merge branch 'main' of https://github.com/NCAR/ccpp-physics into scid…
mzhangw 9085a24
scidoc update
mzhangw 368877c
scidoc
mzhangw 72e606a
add acronyms pages and NMLs for PSL options
mzhangw d42bc73
minor fix
mzhangw 714cfe7
add back Doxygen comments for passing ccpp_prebuild.py
grantfirl 670b978
address reviewers' comments
mzhangw 2139d39
Merge branch 'scidoc_v7' into scidoc_v7_gjf
grantfirl 8442afa
Merge pull request #10 from grantfirl/scidoc_v7_gjf
mzhangw e5fc194
address comments
mzhangw 06ec731
Merge branch 'scidoc_v7' of https://github.com/mzhangw/ccpp-physics i…
mzhangw 33595ba
address comments
mzhangw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
!>\file samfaerosols.F | ||
!! | ||
module samfcnv_aerosols | ||
|
||
implicit none | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be too late for this release, but I think we need to rename this scheme and all references to the "drag suite" to "drag scheme". When I get a chance I will open an issue to make the naming conventions more consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see your point. Please work with scheme PoC on this. It is called suite because it internally has various subcomponent. However, I see how that makes it super confusing for CCPP users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed that it is confusing to call this scheme a "suite". Surely there is a term that can be used that signifies that this scheme has subcomponents than calling it the same term that we reserve for a collection of CCPP schemes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps change "orographic gravity wave drag scheme" to "orographic drag schemes"? I omitted the word 'wave' because the mountain blocking and form drag components are not 'wave' phenomena.