-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scientific documentation for CCPP-SCM v7.0.0 #1077
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI Man, Tks for the updates. Pls see some comments. I am not done, but I thought I'd send you some initial thoughts
physics/GWD/drag_suite.F90
Outdated
@@ -2,14 +2,11 @@ | |||
!! This file is the parameterization of orographic gravity wave | |||
!! drag, mountain blocking, and form drag. | |||
|
|||
!> This module contains the orographic gravity wave drag scheme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be too late for this release, but I think we need to rename this scheme and all references to the "drag suite" to "drag scheme". When I get a chance I will open an issue to make the naming conventions more consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see your point. Please work with scheme PoC on this. It is called suite because it internally has various subcomponent. However, I see how that makes it super confusing for CCPP users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed that it is confusing to call this scheme a "suite". Surely there is a term that can be used that signifies that this scheme has subcomponents than calling it the same term that we reserve for a collection of CCPP schemes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps change "orographic gravity wave drag scheme" to "orographic drag schemes"? I omitted the word 'wave' because the mountain blocking and form drag components are not 'wave' phenomena.
Hi Man, please lmk when these items have been addressed and the website refreshed for final review. Tks
|
@mzhangw Regarding the GFS_NSST scheme, it seems to me like the v4.0 page has a more detailed history and scientific description of the algorithm used along with a nice scientific visualization, though I don't know if it's out-of-date or anything like that. It's not a big deal, just something I noticed while browsing older drafts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mzhangw Please review/approve/merge this: mzhangw#10
There were several changes in this branch that caused ccpp_prebuild to fail. One is that there needs to be an empty !!
line after the htmlinclude
line. Second, you need to keep the 3 line Doxygen markup for DDTs that are needed by the host/physics (the arg_table, htmlinclude, and blank line). My PR into your branch fixes it so that this branch builds.
Changes needed to compile scidoc v7 updates
@ligiabernardet @mkavulich Since you requested changes, please re-review to see if your concerns have been addressed. With 8442afa, this now builds OK. |
physics/docs/pdftxt/GFS_RRTMGP.txt
Outdated
- CSDLFsfc: Downward LW | ||
- CSDSFsfc: Downward SW | ||
- CSULFsfc: Upward LW | ||
- CSULFsfc: Upward LW |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CSULFsfc is duplicated in this context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dustinswales CSDLFsfc: Downward LW is already explained in line 60.
|
||
While the parameterization for smoke and dust representation is used RRFS prototype tests and is included in the | ||
HRRR_gf Suite Definition File, is not active in the CCPP Single Column Model since the smoke and dust tracers are initialized | ||
with new zero values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the parameterization for smoke and dust representation is used by RRFS prototype tests and is included in the
HRRR_gf Suite Definition File, it is not active in the CCPP Single Column Model since the smoke and dust tracers are initialized
with new zero values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple grammar fixes in italics
final website