Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check none enddate in temporal validator #419

Merged
merged 2 commits into from
Sep 27, 2024
Merged

fix: check none enddate in temporal validator #419

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad47efb
check for none enddate
smohiudd Aug 9, 2024
f97338c
optional startdate null
smohiudd Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ingest_api/runtime/src/schema_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@ def check_extent(cls, v):

class TemporalExtent(BaseModel):
startdate: datetime
enddate: datetime
enddate: Union[datetime, None]

@root_validator
def check_dates(cls, v):
if v["startdate"] >= v["enddate"]:
if (v["enddate"] is not None) and (v["startdate"] >= v["enddate"]):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since both start and end can be open in the spec (although not recommended) should we just allow it here, too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah good point, could have null for both start and end. I'll make a change

raise ValueError("Invalid extent - startdate must be before enddate")
return v