fix: check none enddate in temporal validator #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smohiudd
changed the title
anayeaye
reviewed
Aug 9, 2024
|
|
||
| @root_validator | ||
| def check_dates(cls, v): | ||
| if v["startdate"] >= v["enddate"]: | ||
| if (v["enddate"] is not None) and (v["startdate"] >= v["enddate"]): |
There was a problem hiding this comment.
Since both start and end can be open in the spec (although not recommended) should we just allow it here, too?
There was a problem hiding this comment.
yeah good point, could have null for both start and end. I'll make a change
botanical
approved these changes
Sep 27, 2024
anayeaye
added a commit
that referenced
this pull request
Oct 15, 2024
…lidation, add nlcd colormap (#434) **Breaking** feat(routes)!: remove cloudfront distribution and custom alternate domain from backend #422 **Added** feat(raster-api): added custom NLCD colormap #433 feat: add ecr endpoint #432 **Fixed** fix(tests): #425 fix(ingest): improved datetime validations #419 **Changed** ci: remove automated deployments to staging #438
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix temporal validator in cases where a collection has a
nullenddate as per STAC spec: https://github.com/radiantearth/stac-spec/blob/master/collection-spec/collection-spec.md#temporal-extent-objectTested with the following dataset config:
{ "collection": "fldas-soil-moisture-anomalies", "title": "FLDAS Surface Soil Moisture Anomalies", "data_type": "cog", "spatial_extent": { "xmin": -180, "ymin": -60, "xmax": 180, "ymax": 90 }, "temporal_extent": { "startdate": "1982-01-01T00:00:00Z", "enddate": null }, "license": "not-provided", "description": "A 10 km global data product with 40 years of monthly soil moisture anomalies for food and water security monitoring from the Famine Early Warning System Network (FEWS NET) Land Data Assimilation System", "is_periodic": false, "time_density": "month", "sample_files": [ "s3://veda-data-store-staging/fldas-soil-moisture-anomalies/FLDAS_NOAH01_SoilMoi00_10cm_tavg_C_GL_MA_ANOM198201_19820101.tif" ], "discovery_items": [ { "discovery": "s3", "prefix": "fldas-soil-moisture-anomalies/", "bucket": "veda-data-store-staging", "filename_regex": "(.*)FLDAS_NOAH01_SoilMoi00_10cm_tavg_C_GL_MA_ANOM(.*).tif$" } ] }