Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make weather great again #158

Merged
merged 44 commits into from
Jun 14, 2021
Merged

Make weather great again #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
4bff6a1
Re-ordered imports and put module-level documentation where it belongs
chrisveilleux Feb 25, 2021
759cb1a
Merge branch '20.08' into make-weather-great-again
chrisveilleux Mar 17, 2021
10af4d3
refactor weather skill
chrisveilleux Mar 18, 2021
8844017
Refactor the GUI code. Add Mark II specific QML files.
chrisveilleux Apr 12, 2021
20465b2
Update the README file.
chrisveilleux Apr 12, 2021
1a79f9c
Removed unused QML file
chrisveilleux Apr 12, 2021
0ab455e
Added license information block.
chrisveilleux Apr 12, 2021
fd1da49
Add a section for temperatures
chrisveilleux Apr 12, 2021
cb2707c
Add documentation and rename the "generic" QML files to a more descri…
chrisveilleux Apr 13, 2021
6fdea43
Added comments and formatting.
chrisveilleux Apr 14, 2021
747569a
Added comments
chrisveilleux Apr 14, 2021
5cafea4
Fixed a bug introduced during code cleanup
chrisveilleux Apr 14, 2021
f8284f8
Introduce a 16 pixel grid unit property and remove an unused import
chrisveilleux Apr 14, 2021
13526e5
Renamed delegates for consistency, added abstractions to reduce code …
chrisveilleux Apr 15, 2021
782816c
Uncomment the feature files.
chrisveilleux Apr 16, 2021
368c368
Add index out of range handling for hourly requests more than 48 hour…
chrisveilleux Apr 16, 2021
276a2bb
Take today out of the relative day vocabulary file as it was conflict…
chrisveilleux Apr 16, 2021
5b8b6ce
Remove unused import
chrisveilleux Apr 16, 2021
0926281
Minor font size change
chrisveilleux Apr 16, 2021
7c5a76b
New feature files for hourly weather
chrisveilleux Apr 16, 2021
0b31a7f
New xfail scenario example
chrisveilleux Apr 16, 2021
74e994f
Move dialog, vocabulary and regex files to the locale directory as pe…
chrisveilleux Apr 16, 2021
cdfacb6
Add PyCharm IDE files to gitignore
chrisveilleux Apr 16, 2021
b15367d
Add OpenWeatherMap language support.
chrisveilleux Apr 16, 2021
10ea965
Renamed resource files to be consistent with en-us locale.
chrisveilleux Apr 19, 2021
5d38589
Second pass at refactoring, including reworking the dialog classes, r…
chrisveilleux Apr 28, 2021
4c62179
Bug fixes
chrisveilleux Apr 29, 2021
42924ca
Add a new GUI screen for a single day of weather.
chrisveilleux May 1, 2021
a6b73e3
Add a new GUI screen for sunrise and sunset.
chrisveilleux May 3, 2021
aad8a27
Refactored logic that selected an image or animation to use in the GUI
chrisveilleux May 4, 2021
730e0c5
Added location to the top of weather screens that didn't have it.
chrisveilleux May 4, 2021
b39098c
renamed "source" directory to "skill"
chrisveilleux May 5, 2021
a8197b5
tweaks to GUI screens based on design changes
chrisveilleux May 5, 2021
cdac179
small bug fix
chrisveilleux May 6, 2021
05134fb
added location data to the forecast screen
chrisveilleux May 6, 2021
872cf61
renamed dialog and vocab files to be lower case and dash delimited.
chrisveilleux May 10, 2021
9ca144a
applied code review changes
chrisveilleux May 12, 2021
054c9b2
use the new CardDelegate defined in the mycroft-gui repository to abs…
chrisveilleux May 12, 2021
d3e4293
Merge remote-tracking branch 'origin/20.08' into make-weather-great-a…
chrisveilleux May 12, 2021
bb5ab99
resolve merge conflicts
chrisveilleux May 12, 2021
04aca83
apply new dialog file naming convention to tests.
chrisveilleux May 12, 2021
3a19904
fixed errant dialog names found in VK testing.
chrisveilleux May 12, 2021
47b6baa
fix VK test failures.
chrisveilleux May 12, 2021
37de4a5
Move the rest of the old dialog class to the new ones.
chrisveilleux May 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@
*.qmlc
settings.json
.vscode
.idea/**
31 changes: 24 additions & 7 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,43 @@
# <img src='https://rawgithub.com/FortAwesome/Font-Awesome/master/svgs/solid/sun.svg' card_color='#FEE255' width='50' height='50' style='vertical-align:bottom'/> Weather
Weather conditions and forecasts

[![Code style: black](https://img.shields.io/badge/code%20style-black-000000.svg)](https://github.com/psf/black)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be more comfortable leaving this out until we have made a call on what the Mycroft official requirement is.

Copy link
Member Author

@chrisveilleux chrisveilleux May 12, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the code IS formatted using Black. What if someone questions why the lines are longer than 79 characters? This is informational, not prescriptive. We can always remove it.


## About
Get weather conditions, forecasts, expected precipitation and more! By default it will tell
you about your default location, or you can ask for other cities around the world.
Get weather conditions, forecasts, expected precipitation and more! By default, it will tell
you about your device's configured location. You can also ask for other cities around the world.

Current conditions and weather forecasts come from [Open Weather Map](https://openweathermap.org).

For **enclosures** with screen support, conditions are briefly shown using visemes.

The temperature is shown in Celsius or Fahrenheit depending on the preferences set in your [https://home.mycroft.ai](https://home.mycroft.ai) account.
The temperature is shown in Celsius or Fahrenheit depending on the preferences
set in your [https://home.mycroft.ai](https://home.mycroft.ai) account. You can ask
specifically for a unit that differs from your configuration.

## Examples
### Current Conditions
* "What is the weather?"
* "What is the weather in Houston?"

### Daily Forecasts
* "What is the forecast tomorrow?"
* "What is the forecast in London tomorrow?"
* "What is the weather going to be like Tuesday?"
* "What is the weather in Houston?"
* "What is the weather for the next three days?"
* "What is the weather this weekend?"

### Temperatures
* "What's the temperature?"
* "What's the temperature in Paris tomorrow in Celsius?"
* "What's the high temperature tomorrow"
* "Will it be cold on Tuesday"

### Specific Weather Conditions
* "When will it rain next?"
* "How windy is it?"
* "What's the humidity?"
* "Is it going to snow?"
* "What's the temperature?"
* "Is it going to snow in Baltimore?"
* "When is the sunset?"

## Credits
Mycroft AI (@MycroftAI)
Expand Down
Loading