-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make weather great again #158
Merged
Merged
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
4bff6a1
Re-ordered imports and put module-level documentation where it belongs
chrisveilleux 759cb1a
Merge branch '20.08' into make-weather-great-again
chrisveilleux 10af4d3
refactor weather skill
chrisveilleux 8844017
Refactor the GUI code. Add Mark II specific QML files.
chrisveilleux 20465b2
Update the README file.
chrisveilleux 1a79f9c
Removed unused QML file
chrisveilleux 0ab455e
Added license information block.
chrisveilleux fd1da49
Add a section for temperatures
chrisveilleux cb2707c
Add documentation and rename the "generic" QML files to a more descri…
chrisveilleux 6fdea43
Added comments and formatting.
chrisveilleux 747569a
Added comments
chrisveilleux 5cafea4
Fixed a bug introduced during code cleanup
chrisveilleux f8284f8
Introduce a 16 pixel grid unit property and remove an unused import
chrisveilleux 13526e5
Renamed delegates for consistency, added abstractions to reduce code …
chrisveilleux 782816c
Uncomment the feature files.
chrisveilleux 368c368
Add index out of range handling for hourly requests more than 48 hour…
chrisveilleux 276a2bb
Take today out of the relative day vocabulary file as it was conflict…
chrisveilleux 5b8b6ce
Remove unused import
chrisveilleux 0926281
Minor font size change
chrisveilleux 7c5a76b
New feature files for hourly weather
chrisveilleux 0b31a7f
New xfail scenario example
chrisveilleux 74e994f
Move dialog, vocabulary and regex files to the locale directory as pe…
chrisveilleux cdfacb6
Add PyCharm IDE files to gitignore
chrisveilleux b15367d
Add OpenWeatherMap language support.
chrisveilleux 10ea965
Renamed resource files to be consistent with en-us locale.
chrisveilleux 5d38589
Second pass at refactoring, including reworking the dialog classes, r…
chrisveilleux 4c62179
Bug fixes
chrisveilleux 42924ca
Add a new GUI screen for a single day of weather.
chrisveilleux a6b73e3
Add a new GUI screen for sunrise and sunset.
chrisveilleux aad8a27
Refactored logic that selected an image or animation to use in the GUI
chrisveilleux 730e0c5
Added location to the top of weather screens that didn't have it.
chrisveilleux b39098c
renamed "source" directory to "skill"
chrisveilleux a8197b5
tweaks to GUI screens based on design changes
chrisveilleux cdac179
small bug fix
chrisveilleux 05134fb
added location data to the forecast screen
chrisveilleux 872cf61
renamed dialog and vocab files to be lower case and dash delimited.
chrisveilleux 9ca144a
applied code review changes
chrisveilleux 054c9b2
use the new CardDelegate defined in the mycroft-gui repository to abs…
chrisveilleux d3e4293
Merge remote-tracking branch 'origin/20.08' into make-weather-great-a…
chrisveilleux bb5ab99
resolve merge conflicts
chrisveilleux 04aca83
apply new dialog file naming convention to tests.
chrisveilleux 3a19904
fixed errant dialog names found in VK testing.
chrisveilleux 47b6baa
fix VK test failures.
chrisveilleux 37de4a5
Move the rest of the old dialog class to the new ones.
chrisveilleux File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,3 +2,4 @@ | |
*.qmlc | ||
settings.json | ||
.vscode | ||
.idea/** |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be more comfortable leaving this out until we have made a call on what the Mycroft official requirement is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But the code IS formatted using Black. What if someone questions why the lines are longer than 79 characters? This is informational, not prescriptive. We can always remove it.