Delete timeline causes crash on windows #680

[wolfseifert]

No description provided.

[Murmele]

Can you fix the formatting?

[wolfseifert]

I made the changes without reformatting, directly at github. I have no idea what is wrong with the formatting. Is the existing code compliant with this formatting check? Maybe you should disable the formatting check for PRs.

[Murmele]

I made the changes without reformatting, directly at github. I have no idea what is wrong with the formatting. Is the existing code compliant with this formatting check? Maybe you should disable the formatting check for PRs.

you have to execute the cl-fmt.sh script. Maybe because the line got longer and then it should be wrapped or something like this.

 ./src/ui/MainWindow.cpp:204:42: error: code should be clang-formatted [-Wclang-format-violations]
  connect(timeline, &QTimeLine::finished, [timeline] { timeline->deleteLater(); });
                                         ^
Failed on file: ./src/ui/MainWindow.cpp

./src/ui/RepoView.cpp:893:42: error: code should be clang-formatted [-Wclang-format-violations]
  connect(timeline, &QTimeLine::finished, [timeline] { timeline->deleteLater(); });
                                         ^
Failed on file: ./src/ui/RepoView.cpp

[wolfseifert]

Done.

[Murmele]

Thanks :) i will merge when ci runs through