Merge pull request #693 from wolfseifert/delete-timeline-causes-crash…

…-on-windows-#680 Delete timeline causes crash on windows #680
Murmele · Feb 20, 2024 · d37a32f · d37a32f
2 parents dad3383 + 3cd3ddb
commit d37a32f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/ui/MainWindow.cpp b/src/ui/MainWindow.cpp
@@ -201,7 +201,8 @@ void MainWindow::setSideBarVisible(bool visible) {
     splitter->setSizes({static_cast<int>(pos * value), 1});
   });
 
-  connect(timeline, &QTimeLine::finished, [timeline] { delete timeline; });
+  connect(timeline, &QTimeLine::finished,
+          [timeline] { timeline->deleteLater(); });
 
   timeline->start();
 }

diff --git a/src/ui/RepoView.cpp b/src/ui/RepoView.cpp
@@ -890,7 +890,8 @@ void RepoView::setLogVisible(bool visible) {
     setSizes({1, static_cast<int>(pos * value)});
   });
 
-  connect(timeline, &QTimeLine::finished, [timeline] { delete timeline; });
+  connect(timeline, &QTimeLine::finished,
+          [timeline] { timeline->deleteLater(); });
 
   timeline->start();
 }