Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard against fetch failures in textPositions #942

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

allanlasser
Copy link
Member

Fixes #939

@allanlasser allanlasser requested a review from eyeseast December 4, 2024 20:51
Copy link

netlify bot commented Dec 4, 2024

Deploy Preview for documentcloud-frontend-next ready!

Name Link
🔨 Latest commit 9fae072
🔍 Latest deploy log https://app.netlify.com/sites/documentcloud-frontend-next/deploys/6750c0ac71da360008f98cd5
😎 Deploy Preview https://deploy-preview-942.muckcloud.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 24 (🔴 down 30 from production)
Accessibility: 86 (🟢 up 1 from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Dec 4, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 30.99% 6807 / 21964
🔵 Statements 30.99% 6807 / 21964
🔵 Functions 49.11% 276 / 562
🔵 Branches 75.52% 1037 / 1373
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/lib/api/documents.ts 91.5% 89.47% 96.96% 91.5% 89-108, 179-181, 186-187, 204-210, 516-518
src/lib/api/tests/documents.test.ts 98.81% 98.96% 88.88% 98.81% 653-660
Generated in workflow #446 for commit 9fae072 by the Vitest Coverage Report Action

Copy link
Collaborator

@eyeseast eyeseast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we're actually calling this function anywhere, since we use embedded text in PDFs, but this seems like a good change in case we do start using it.

@allanlasser allanlasser merged commit c4d6034 into main Dec 4, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Guard against fetch failures in getTextPositions
2 participants