Merge pull request #942 from MuckRock/allanlasser/issue939

Guard against fetch failures in `textPositions`
MuckRock · Dec 4, 2024 · c4d6034 · c4d6034
2 parents fbf37a5 + 9fae072
commit c4d6034
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/lib/api/documents.ts b/src/lib/api/documents.ts
@@ -209,12 +209,14 @@ export async function textPositions(
     }
   }
 
-  const resp = await fetch(url).catch(console.error);
-  if (!resp || isErrorCode(resp.status)) {
+  try {
+    const resp = await fetch(url);
+    if (!resp || isErrorCode(resp.status)) return [];
+    return resp.json();
+  } catch (e) {
+    console.error(e);
     return [];
   }
-
-  return resp.json();
 }
 
 /**

diff --git a/src/lib/api/tests/documents.test.ts b/src/lib/api/tests/documents.test.ts
@@ -246,6 +246,9 @@ describe("document fetching", () => {
     const t = await documents.textPositions(document, 1, mockFetch);
 
     expect(t).toMatchObject(textPositions);
+
+    mockFetch.mockRejectedValue(new Error("Failed to fetch"));
+    expect(await documents.textPositions(document, 1, mockFetch)).toEqual([]);
   });
 });