Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sveltekit viewer layout #479

Merged
merged 19 commits into from
Mar 26, 2024
Merged

Sveltekit viewer layout #479

merged 19 commits into from
Mar 26, 2024

Conversation

eyeseast
Copy link
Collaborator

@eyeseast eyeseast commented Mar 21, 2024 •
edited
Loading

All the sidebar stuff. Basic links wired up. Fixed deploy preview links.

@eyeseast eyeseast requested a review from allanlasser March 21, 2024 21:36
@netlify Netlify
Copy link

netlify bot commented Mar 21, 2024 •
edited
Loading

✅ Deploy Preview for documentcloud-frontend ready!

Name Link
🔨 Latest commit 6d419b0
🔍 Latest deploy log https://app.netlify.com/sites/documentcloud-frontend/deploys/6603338914ba4b0008a43f7b
😎 Deploy Preview https://deploy-preview-479.muckcloud.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@eyeseast eyeseast marked this pull request as ready for review March 25, 2024 19:39
allanlasser
allanlasser requested changes Mar 26, 2024
View reviewed changes
Copy link
Member

@allanlasser allanlasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly small things that I suggested changes for! Looks good overall

src/style/kit.css Outdated Show resolved Hide resolved
src/style/kit.css Outdated Show resolved Hide resolved
src/routes/documents/[id]-[slug]/sidebar/Sections.svelte Outdated Show resolved Hide resolved
src/routes/documents/[id]-[slug]/sidebar/Sections.svelte Outdated Show resolved Hide resolved
src/routes/documents/[id]-[slug]/sidebar/Sections.svelte Outdated Show resolved Hide resolved
src/routes/documents/[id]-[slug]/sidebar/Sections.svelte Outdated Show resolved Hide resolved
src/routes/documents/[id]-[slug]/sidebar/Projects.svelte Outdated Show resolved Hide resolved
src/routes/documents/[id]-[slug]/sidebar/Data.svelte Outdated Show resolved Hide resolved
src/routes/documents/[id]-[slug]/sidebar/Actions.svelte Show resolved Hide resolved
eyeseast and others added 8 commits March 26, 2024 16:26
@eyeseast eyeseast mentioned this pull request Mar 26, 2024
Closed
@eyeseast eyeseast requested a review from allanlasser March 26, 2024 20:36
allanlasser
allanlasser requested changes Mar 26, 2024
View reviewed changes
Copy link
Member

@allanlasser allanlasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When suggesting changes, I forgot that the 16px icons also need to be included for the group titles—fixed that.

src/routes/documents/[id]-[slug]/sidebar/Data.svelte Outdated Show resolved Hide resolved
src/routes/documents/[id]-[slug]/sidebar/Projects.svelte Outdated Show resolved Hide resolved
src/routes/documents/[id]-[slug]/sidebar/Sections.svelte Outdated Show resolved Hide resolved
eyeseast and others added 3 commits March 26, 2024 16:43
@eyeseast @allanlasser
Both sizes
891bde0 
Co-authored-by: Allan Lasser <[email protected]>
@eyeseast @allanlasser
Both sizes
ad5ea8b 
Co-authored-by: Allan Lasser <[email protected]>
@eyeseast @allanlasser
Both sizes
6d419b0 
Co-authored-by: Allan Lasser <[email protected]>
allanlasser
allanlasser approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@allanlasser allanlasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin good!

@eyeseast eyeseast merged commit 5a12fba into sveltekit Mar 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allanlasser allanlasser allanlasser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eyeseast @allanlasser