Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SidebarItem should handle links #488

Closed
eyeseast opened this issue Mar 26, 2024 · 0 comments · Fixed by #503
Closed

SidebarItem should handle links #488

eyeseast opened this issue Mar 26, 2024 · 0 comments · Fixed by #503
Assignees
@eyeseast
Labels
enhancement New feature or request
Milestone
SvelteKit Beta

Comments

@eyeseast
Copy link
Collaborator

This is good for now, but I think we'll need to rework the SidebarItem slightly to handle links. I think the entire "row" should behave like a link when that's the action it represents.

Originally posted by @allanlasser in #479 (comment)
@eyeseast eyeseast added this to the SvelteKit milestone Mar 26, 2024
@eyeseast eyeseast added the enhancement New feature or request label Mar 26, 2024
@allanlasser allanlasser mentioned this issue Apr 2, 2024
Merged
@allanlasser allanlasser linked a pull request Apr 2, 2024 that will close this issue
Use SidebarItem as links in viewer sidebars #503
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyeseast eyeseast

Labels
enhancement New feature or request
Projects
None yet
Milestone
SvelteKit Beta
Development

Successfully merging a pull request may close this issue.

Use SidebarItem as links in viewer sidebars MuckRock/documentcloud-frontend
2 participants
@eyeseast @allanlasser