Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Umbrellas #575
Adds Umbrellas #575
Changes from 17 commits
0ced948
96c5299
a51c4e3
4b0aa40
d6dddfe
75e3db1
aa0e0e9
ec2d154
38397b9
481719d
187b37e
a73db35
2f54b80
b4254ce
ed97535
5f02212
b8c7dcb
6cef73e
8d94d95
8b060b5
84bfad1
afabfa2
46fa820
9039161
d6a2e13
81a319f
940291d
b41754a
e6cc7dc
7245607
31cfac1
576d626
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way you currently have it, this trait will be permanent if you open up an umbrella and then just drop it.
Also
INNATE_TRAIT
is an inappropriate trait sourceYou'd need to add a system so that it adds the trait in
pickup
if it's active, removes the trait indropped
regardless if it's active or not, and then inon_transform
you'd have this code still*.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*Except I think 1.
user
is not nullsafe in this code, and 2. this would give people using telekinesis to open the umbrella rad immunityThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I managed to do most of that apart from the telekinesis thing. I have NO idea how to deal with that.