-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Umbrellas #575
Adds Umbrellas #575
Conversation
In theory it is possible to add colour variations like with screwdrivers, but that is out of my scope. |
Based Drag core PR |
Co-authored-by: MrMelbert <[email protected]>
Co-authored-by: MrMelbert <[email protected]>
/obj/item/umbrella/volkan/on_transform(obj/item/source, mob/user, active) | ||
. = ..() | ||
if(active) | ||
ADD_TRAIT(user, TRAIT_RADIMMUNE, INNATE_TRAIT) | ||
else | ||
REMOVE_TRAIT(user, TRAIT_RADIMMUNE, INNATE_TRAIT) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way you currently have it, this trait will be permanent if you open up an umbrella and then just drop it.
Also INNATE_TRAIT
is an inappropriate trait source
You'd need to add a system so that it adds the trait in pickup
if it's active, removes the trait in dropped
regardless if it's active or not, and then in on_transform
you'd have this code still*.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*Except I think 1. user
is not nullsafe in this code, and 2. this would give people using telekinesis to open the umbrella rad immunity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I managed to do most of that apart from the telekinesis thing. I have NO idea how to deal with that.
What's this?
Adds umbrellas to the game!
They can open and close and they look real neat!
Why?
Because we need handheld parasols or umbrellas for the beach!
TO DO:
Sprites so far:
Basic umbrella
inhand open:
inhand closed:
Black Parasol
Inhand open:
inhand closed:
Volkan's umbrella
Inhand open:
Inhand closed: