Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Synth Customisation Options #500
New Synth Customisation Options #500
Changes from 23 commits
e981d0e
5d4e7e8
2c3adc5
0ab22f1
67197ad
b176c94
94c7d9d
5ea3503
e04782e
260e604
f5ae2ec
22d6de5
6e98c96
9dbee38
cd94bb4
f554511
2587ff3
789a46c
4fec040
1043565
73f6647
60578b3
433e446
5cd7cee
21d5bb3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need an bespoke type for this, I think instead all you need to do is when you make the global list
(
init_sprite_accessory_subtypes
), you addadd_blank = TRUE
to the call, and that adds an empty sprite accessory for youThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doing that seems to introduce a bug where the preferences menu shows a head cover applied to the option that is supposed to be blank.
Not sure what that is about so I will hold back on this for now.