New Synth Customisation Options #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… heads. This is not quite working, but its almost there. Probably a small bug. Needs sprites.
…gs are bugging out and i cannot tick this. no idea why.
…he dme I didn't touch anything...
…g the hew heads render under hats.
|
I got it working! It just cannot render under hats. If I set layers = EXTERNAL_ADJACENT it just dissapears. It basically has to be on the top layer??? Idk whats going on there. |
Constellado
changed the title
Constellado
changed the title
Constellado
changed the title
Constellado
changed the title
MrMelbert
reviewed
Jun 22, 2024
maplestation_modules/code/modules/mob/living/carbon/human/species_types/synth/synth.dm
Outdated
Show resolved
Hide resolved
maplestation_modules/code/modules/mob/living/carbon/human/species_types/synth/synth.dm
Outdated
Show resolved
Hide resolved
maplestation_modules/code/modules/mob/living/carbon/human/species_types/synth/synth.dm
Outdated
Show resolved
Hide resolved
Comment on lines
+516
to
+518
| /datum/sprite_accessory/synth_head_cover/none // for those that don't want a cover. | ||
| name = "None" | ||
| icon_state = null |
There was a problem hiding this comment.
I don't think you need an bespoke type for this, I think instead all you need to do is when you make the global list
(init_sprite_accessory_subtypes), you add add_blank = TRUE to the call, and that adds an empty sprite accessory for you
There was a problem hiding this comment.
doing that seems to introduce a bug where the preferences menu shows a head cover applied to the option that is supposed to be blank.
Not sure what that is about so I will hold back on this for now.
…ies_types/synth/synth.dm Co-authored-by: MrMelbert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds options for synth heads!
Without a head cover:
Sprites are from me apart from the IPC sprite, which is from "icons\mob\clothing\head\costume.dmi".
Helm default:
Helm white:
IPC (was from somewhere else in the code base)
(notice! It hides hats due to the huge size!)
Also this option!!
