Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds R_BAN, R_DEBUG, or R_SERVER requirement to seeing ahelp ticket popups / tab #366

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions code/controllers/subsystem/statpanel.dm
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,8 @@ SUBSYSTEM_DEF(statpanels)
target.stat_panel.send_message("update_mc", list("mc_data" = mc_data, "coord_entry" = coord_entry))

/datum/controller/subsystem/statpanels/proc/set_tickets_tab(client/target)
if(!check_rights_for(target, R_BAN|R_DEBUG|R_SERVER)) // NON-MODULE CHANGE
return
var/list/ahelp_tickets = GLOB.ahelp_tickets.stat_entry()
target.stat_panel.send_message("update_tickets", ahelp_tickets)
var/datum/interview_manager/m = GLOB.interviews
Expand Down
2 changes: 2 additions & 0 deletions code/modules/admin/verbs/adminhelp.dm
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,8 @@ GLOBAL_DATUM_INIT(ahelp_tickets, /datum/admin_help_tickets, new)

//send this msg to all admins
for(var/client/X in GLOB.admins)
if(!check_rights_for(X, R_BAN|R_DEBUG|R_SERVER)) // NON-MODULE CHANGE
continue
if(X.prefs.toggles & SOUND_ADMINHELP)
SEND_SOUND(X, sound('sound/effects/adminhelp.ogg'))
window_flash(X, ignorepref = TRUE)
Expand Down
4 changes: 4 additions & 0 deletions code/modules/admin/verbs/adminpm.dm
Original file line number Diff line number Diff line change
Expand Up @@ -555,6 +555,8 @@
else
log_admin_private("PM: [our_name]->External: [sanitize_text(trim(raw_message))]")
for(var/client/lad in GLOB.admins)
if(!check_rights_for(lad, R_BAN|R_DEBUG|R_SERVER)) // NON-MODULE CHANGE
continue
to_chat(lad,
type = MESSAGE_TYPE_ADMINPM,
html = span_notice("<B>PM: [our_linked_ckey]-&gt;External:</B> [keyword_parsed_msg]"),
Expand Down Expand Up @@ -584,6 +586,8 @@
for(var/client/lad in GLOB.admins)
if(lad.key == key || lad.key == recipient_key) //check to make sure client/lad isn't the sender or recipient
continue
if(!check_rights_for(lad, R_BAN|R_DEBUG|R_SERVER)) // NON-MODULE CHANGE
continue
to_chat(lad,
type = MESSAGE_TYPE_ADMINPM,
html = span_notice("<B>PM: [our_linked_ckey]-&gt;[recipient_linked_ckey]:</B> [keyword_parsed_msg]") ,
Expand Down
Loading