Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds R_BAN, R_DEBUG, or R_SERVER requirement to seeing ahelp ticket popups / tab #366

Closed
wants to merge 1 commit into from

Conversation

MrMelbert
Copy link
Owner

By request: Admins require one of R_BAN (banning permissions) R_DEBUG (debug permissions) or R_SERVER (server restart permissions) to see ahelps.

Also: This is very much not foolproof, as long as someone knows how VV works they you can unwrap the ahelp tracker pretty easily. However it should serve for our purposes (and is very easily caught).

Also also: This also half affects interviews because the panels are intertwined, but I couldn't bring myself to care about it since we don't do in game interviews. In fact I imagine they're disabled.

Also also also: this is difficult to test, so should be test-merged on a pre-round or something.

@MrMelbert MrMelbert added the Adjustment Tweaking something to be better, maybe label Nov 1, 2023
@CRITAWAKETS
Copy link
Contributor

CRITAWAKETS commented Nov 2, 2023

Why is debug permission in the list specifically? It's given out to event runners since it's the only way to do things like manually spawning in cargo crates or map templates.

@MrMelbert
Copy link
Owner Author

Why is debug permission in the list specifically? It's given out to event runners since it's the only way to do things like manually spawning in cargo crates or map templates.

I left it in for when someone (me) needs to respond to ahelps involving bugs.
When I gave it a quick glance earlier I didn't see a lot behind R_DEBUG that would make it a must-have for running events.
You can always change any verbs which require debug to not require it.

@MrMelbert MrMelbert added Testing Required What's the worst that could happen? A lot. Non-Module Code Touches main files. I'd make an action for this but I'm lazy. labels Nov 4, 2023
@MrMelbert MrMelbert closed this Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Adjustment Tweaking something to be better, maybe Non-Module Code Touches main files. I'd make an action for this but I'm lazy. Testing Required What's the worst that could happen? A lot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants